Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fwd port, UP-84] perform upgrade verification in softFetchInterface #20127

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

paulbrauner-da
Copy link
Contributor

Fwd port of #20110.

The changes to SBuiltinFun required a bit of manual intervention and could use a second pair of eyes.

@paulbrauner-da paulbrauner-da changed the base branch from main to pb/20035-fwd-port October 18, 2024 14:54
@paulbrauner-da paulbrauner-da marked this pull request as ready for review October 18, 2024 14:57
…20110)

* add failing tests for signatories and observers

* add ensure clause dynamic exercise test

* add dynamic exercise/fetch tests for changed keys

* fix bug
@paulbrauner-da paulbrauner-da changed the title [fwd port] Fix up-84: softFetchInterface does not perform upgrade verification [fwd port, UP-784] perform upgrade verification in softFetchInterface Oct 23, 2024
@paulbrauner-da paulbrauner-da changed the title [fwd port, UP-784] perform upgrade verification in softFetchInterface [fwd port, UP-84] perform upgrade verification in softFetchInterface Oct 23, 2024
@paulbrauner-da paulbrauner-da merged commit 25849f1 into pb/20035-fwd-port Oct 23, 2024
2 checks passed
@paulbrauner-da paulbrauner-da deleted the pb/20110-fwd-port branch October 23, 2024 13:01
@paulbrauner-da
Copy link
Contributor Author

Accidentally merged into #20126, which I will merge as is since this PR was approved.

paulbrauner-da added a commit that referenced this pull request Oct 23, 2024
…in softFetchInterface (#20126)

* fix local contract upgrade (#20035)

* test for local contract upgrade

* fix fetchAny for local contracts

* add ex and ex by key tests

* add local contract tests to ExceptionsTest

* add fetch by key test

* Add tests for dynamic exercise.

* Fix up-84: softFetchInterface does not perform upgrade verification (#20110) (#20127)

* add failing tests for signatories and observers

* add ensure clause dynamic exercise test

* add dynamic exercise/fetch tests for changed keys

* fix bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants