Fix get-daml.sh for Linux aarch64 #19958
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -127,7 +127,7 @@ elif [ "$major" = "2" ] && [ "$minor" -ge "9" ]; then | |
| platform= | ||
| ;; | ||
| linux-aarch64) | ||
| platform= | ||
| ;; | ||
| linux-x86_64) | ||
| platform= | ||
|
|
@@ -149,7 +149,7 @@ elif [ "$major" -ge "3" ]; then | |
| platform=-x86_64 | ||
| ;; | ||
| linux-aarch64) | ||
|
There was a problem hiding this comment. I don't think you want this change, as it looks like for major version 3 and up they do have these platform-specific artifacts, e.g. https://github.com/digital-asset/daml/releases/tag/v3.2.0-snapshot.20240911.0 There was a problem hiding this comment. Agree, we do have these artifacts for 3x, so this part should be undone. |
||
| platform=-x86_64 | ||
| ;; | ||
| linux-x86_64) | ||
| platform=-x86_64 | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code path now always has the
platformas empty. We don't support arch64 linux in 2.9 at all right now, so we should just eliminate this case.I'd remove the case for
elif [ "$major" = "2" ] && [ "$minor" -ge "9" ]; then, and change the previouselif [ "$major" = "2" ] && [ "$minor" -le "8" ]; thento simplyelif [ "$major" = "2" ]; thenThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samuel-williams-da We're still running the
Linux (arm)job on CI forrelease/2.9.xe.g.
https://dev.azure.com/digitalasset/daml/_build/results?buildId=175828&view=logs&jobId=61ac79bb-734c-5c5d-b939-064aaa72fe3b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right sorry, we don't release any aarch64 artifacts in 2.9 is what I mean.