Fix get-daml.sh for Linux aarch64 #19958
Conversation
Fix get-daml.sh for Linux aarch64
|
|
| @@ -149,7 +149,7 @@ elif [ "$major" -ge "3" ]; then | |||
| platform=-x86_64 | |||
| ;; | |||
| linux-aarch64) | |||
| platform=-aarch64 | |||
There was a problem hiding this comment.
I don't think you want this change, as it looks like for major version 3 and up they do have these platform-specific artifacts, e.g.
https://github.com/digital-asset/daml/releases/tag/v3.2.0-snapshot.20240911.0
There was a problem hiding this comment.
Agree, we do have these artifacts for 3x, so this part should be undone.
| @@ -127,7 +127,7 @@ elif [ "$major" = "2" ] && [ "$minor" -ge "9" ]; then | |||
| platform= | |||
| ;; | |||
| linux-aarch64) | |||
| platform=-aarch64 | |||
There was a problem hiding this comment.
This code path now always has the platform as empty. We don't support arch64 linux in 2.9 at all right now, so we should just eliminate this case.
I'd remove the case for elif [ "$major" = "2" ] && [ "$minor" -ge "9" ]; then, and change the previous elif [ "$major" = "2" ] && [ "$minor" -le "8" ]; then to simply elif [ "$major" = "2" ]; then
There was a problem hiding this comment.
@samuel-williams-da We're still running the Linux (arm) job on CI for release/2.9.x
e.g.
https://dev.azure.com/digitalasset/daml/_build/results?buildId=175828&view=logs&jobId=61ac79bb-734c-5c5d-b939-064aaa72fe3b
There was a problem hiding this comment.
Ah right sorry, we don't release any aarch64 artifacts in 2.9 is what I mean.
| @@ -149,7 +149,7 @@ elif [ "$major" -ge "3" ]; then | |||
| platform=-x86_64 | |||
| ;; | |||
| linux-aarch64) | |||
| platform=-aarch64 | |||
There was a problem hiding this comment.
Agree, we do have these artifacts for 3x, so this part should be undone.
|
Thanks for spotting this though! |
Fix get-daml.sh for Linux aarch64