Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[upgrades, 2.x] NeedUpgradeVerification is raised for local contracts, which it can't access #20282

Open
paulbrauner-da opened this issue Nov 11, 2024 · 0 comments
Open

[upgrades, 2.x] NeedUpgradeVerification is raised for local contracts, which it can't access #20282

paulbrauner-da opened this issue Nov 11, 2024 · 0 comments
Assignees
@paulbrauner-da
Labels
upgrades

Comments

@paulbrauner-da
Copy link
Contributor

As a result, any attempt to upgrade a local contract fails with a wrong "metadata has changed" error message. This wasn't caught by #20035 because the unit tests ignore the NeedUpgradeVerification questions and always return "ok".

We need to:

  • handle the upgrade verification of at least local contracts in the engine
  • change our unit tests to answer NeedUpgradeVerification questions correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulbrauner-da paulbrauner-da

Labels
upgrades
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@paulbrauner-da