Fix local contract upgrade #20296
Open
Fix local contract upgrade #20296
+1,153
−225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbrauner-da
force-pushed
the
pb/fix-local-contracts
branch
from
934174c
to
c95b04e
Compare
sdk/daml-lf/interpreter/src/main/scala/com/digitalasset/daml/lf/speedy/SBuiltin.scala
Outdated
Show resolved
Hide resolved
| signatories = recomputed.signatories, | ||
| observers = recomputed.observers, | ||
| keyOpt = recomputed.keyOpt.map(_.globalKeyWithMaintainers), | ||
| msg = errors.mkString("['", "', '", "']"), |
There was a problem hiding this comment.
I wonder if we do not want to keep the result of the two evaluations.
There was a problem hiding this comment.
Created an issue and added a TODO
paulbrauner-da
force-pushed
the
pb/fix-local-contracts
branch
from
b7ce1f0
to
67f14f3
Compare
paulbrauner-da
force-pushed
the
pb/fix-local-contracts
branch
from
67f14f3
to
e8a87f2
Compare
Co-authored-by: Remy <[email protected]>
paulbrauner-da
force-pushed
the
pb/fix-local-contracts
branch
from
e8a87f2
to
7498a33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20282.
We now always perform the upgrade validation check in the engine, so the
NeedUpgradeVerificationquestion is effecively unused. I'll remove it in a latter PR as it will require quite some cleanup.I've removed test cases that test impossible situations if we assume the upload and type checkers have run, and which now fail because we try to import values.
I added a bunch of daml-script tests as a sanity check, but I don't cover the entire space (disclosed contracts, fetch, fetch by interface, etc.). I plan to do that as part of the "one true test" so I don't want to replicate too much work here.