Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local contracts are not upgraded #19905

Closed
samuel-williams-da opened this issue Sep 10, 2024 · 2 comments
Closed

Local contracts are not upgraded #19905

samuel-williams-da opened this issue Sep 10, 2024 · 2 comments
Labels
upgrades

Comments

@samuel-williams-da
Copy link
Contributor

samuel-williams-da commented Sep 10, 2024 •
edited by remyhaemmerle-da
Loading

Local contracts (those contract created withing a transactions) are not upgraded when fetch/exercise with a different version.
Those failed with WronglyTypeContract Error.

the test "signatories in local contract" in this branch show the issue.

The missing upgrade is located in FetchTemplate SBuiltinFun.
@remyhaemmerle-da remyhaemmerle-da changed the title Local contract doesn't do upgrades Local contracts are not upgraded Sep 10, 2024
@dylant-da
Copy link
Contributor

Delaying until Remy gets back, unless upgrade squad says elsewise

@paulbrauner-da
Copy link
Contributor

This is fixed by #20035 in the sense that we now perform upgrades for local contracts. So closing this. But these upgrades always fail for now, see #20282.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
upgrades
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@moisesackerman-da @dylant-da @samuel-williams-da @paulbrauner-da