Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce nodiscared warning/error [do not review] #8038

Closed
wants to merge 4 commits into from
Closed

Introduce nodiscared warning/error [do not review] #8038

wants to merge 4 commits into from

Conversation

thomasspriggs
Copy link
Collaborator

This PR introduces a nodiscared warning/error This is so that we can confirm it is reported on each of our supported
platforms. This is based on top of #8036 for examining the behaviour of the changes in that PR.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@thomasspriggs
Use [[nodiscard]] attribute for all build systems
c225302 
As we now require `C++17` support, the `[[nodiscard]]` attribute is
required to be supported across all platforms.
@thomasspriggs
Replace usages of NODISCARD macro with [[nodiscard]] attribute
2d6557c 
This makes it more straight forward for new maintainers with
pre-existing C++17 knowledge to read our code base without learning
`NODISCARD`, which is specific to our codebase.
@thomasspriggs
Remove nodiscard.h
0857208 
Because it is no longer needed.
@thomasspriggs
Introduce nodiscared warning/error
1fe3e58 
So that we can confirm it is reported on each of our supported
platforms.
@thomasspriggs thomasspriggs self-assigned this Nov 15, 2023
This was referenced Nov 15, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel will be requested when the pull request is marked ready for review peterschrammel is a code owner

@TGWDB TGWDB Awaiting requested review from TGWDB TGWDB will be requested when the pull request is marked ready for review TGWDB is a code owner

@martin-cs martin-cs Awaiting requested review from martin-cs martin-cs will be requested when the pull request is marked ready for review martin-cs is a code owner

@kroening kroening Awaiting requested review from kroening kroening will be requested when the pull request is marked ready for review kroening is a code owner

@tautschnig tautschnig Awaiting requested review from tautschnig tautschnig will be requested when the pull request is marked ready for review tautschnig is a code owner

Assignees

@thomasspriggs thomasspriggs

Labels
do not review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thomasspriggs