Use the C++17 standard [[nodiscard]] attribute directly
#8036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasspriggs
added
the
Version 6
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8036 +/- ##
========================================
Coverage 79.09% 79.09%
========================================
Files 1699 1699
Lines 196508 196508
========================================
Hits 155430 155430
Misses 41078 41078 ☔ View full report in Codecov by Sentry. |
As we now require `C++17` support, the `[[nodiscard]]` attribute is required to be supported across all platforms.
This makes it more straight forward for new maintainers with pre-existing C++17 knowledge to read our code base without learning `NODISCARD`, which is specific to our codebase.
Because it is no longer needed.
thomasspriggs
force-pushed
the
tas/nonodiscard
branch
from
8cfac64 to
0857208
Compare
esteffin
approved these changes
Nov 14, 2023
tautschnig
approved these changes
Nov 14, 2023
7 tasks
|
I'd like to check how nodiscard issues are reported across each of the platforms we support, before I move this PR out of draft and merge it. I have raised #8038 for this purpose. |
|
Looks like the error/warning reporting is the same before and after this PR. Therefore I am now happy for this to be merged. |
thomasspriggs
requested review from
peterschrammel,
NlightNFotis,
TGWDB,
martin-cs and
kroening
as code owners
TGWDB
approved these changes
Nov 15, 2023
peterschrammel
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we now require
C++17support, the[[nodiscard]]attribute should be required to be supported across all platforms. Using it directly makes it more straight forward for new maintainers with pre-existing C++17 knowledge to read our code base without learningNODISCARD, which is specific to our codebase.