chore: upgrade Storybook to v8.3.6 #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HendrikThePendric
approved these changes
Nov 6, 2024
HendrikThePendric
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key features
cli-app-scriptsand Webpack 5ConfigProviderin the PeriodDimension stories to avoid crashesDescription
In another PR I had to disable the Storybook build from package.json due to compiling issues.
The reason that happened is the updated version of
cli-app-scriptswhich updates React scripts and thus Webpack.The old Storybook version is not compatible with Webpack 5.
This PR upgrades Storybook to a recent version which works with Webpack 5, thus allows us to update
cli-app-scriptswhich is required for the new plugin system.Known issues
eslint-plugin-reactcaused the Stoybook to not build correctly. The root cause was 2 different versions of theeslintdependency. This has been solved by using a resolution foreslint.Screenshots