Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Maven #276

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Cleanup Maven #276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions e2e/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,13 @@
<parent>
<groupId>org.dhatim</groupId>
<artifactId>fastexcel-parent</artifactId>
<version>0-SNAPSHOT</version>
<version>0.16.0-SNAPSHOT</version>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this set during the publish process (and not updated via commit in the pom)?

Copy link
Contributor Author

@zorglube zorglube Feb 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but it's not enough, I think.

It's set during the release process, but to be consistent into a Maven life cycle, it should evoluate into the master branch release after release.

The version change (x.x.x-SNAPSHOT -> x.x.x -> x.x+1.x-SNAPSHOT) plus tagging, commits and publishing is totally handled b the Maven Release plugin.

<relativePath>../pom.xml</relativePath>
</parent>
<artifactId>fastexcel-e2e</artifactId>
<name>Fastexcel End-to-End tests</name>
<url>https://github.com/dhatim/fastexcel</url>

<properties>
<jmh.version>1.36</jmh.version>
</properties>

<dependencies>
<dependency>
<groupId>org.dhatim</groupId>
Expand Down Expand Up @@ -46,13 +42,13 @@
<dependency>
<groupId>org.openjdk.jmh</groupId>
<artifactId>jmh-core</artifactId>
<version>${jmh.version}</version>
<version>1.36</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.openjdk.jmh</groupId>
<artifactId>jmh-generator-annprocess</artifactId>
<version>${jmh.version}</version>
<version>1.36</version>
<scope>test</scope>
</dependency>
<dependency>
Expand Down
2 changes: 1 addition & 1 deletion fastexcel-reader/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<parent>
<groupId>org.dhatim</groupId>
<artifactId>fastexcel-parent</artifactId>
<version>0-SNAPSHOT</version>
<version>0.16.0-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>
<artifactId>fastexcel-reader</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion fastexcel-writer/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<parent>
<groupId>org.dhatim</groupId>
<artifactId>fastexcel-parent</artifactId>
<version>0-SNAPSHOT</version>
<version>0.16.0-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
10 changes: 4 additions & 6 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

<groupId>org.dhatim</groupId>
<artifactId>fastexcel-parent</artifactId>
<version>0-SNAPSHOT</version>
<version>0.16.0-SNAPSHOT</version>
<packaging>pom</packaging>

<modules>
Expand Down Expand Up @@ -40,8 +40,6 @@
<properties>
<maven.compiler.target>1.8</maven.compiler.target>
<maven.compiler.source>1.8</maven.compiler.source>
<junit.jupiter.version>5.9.2</junit.jupiter.version>
<junit.platform.version>1.3.2</junit.platform.version>
<enforcer.fail>false</enforcer.fail>
</properties>

Expand All @@ -50,7 +48,7 @@
<dependency>
<groupId>org.junit</groupId>
<artifactId>junit-bom</artifactId>
<version>${junit.jupiter.version}</version>
<version>5.9.2</version>
<scope>import</scope>
<type>pom</type>
</dependency>
Expand All @@ -75,12 +73,12 @@
<dependency>
<groupId>org.dhatim</groupId>
<artifactId>fastexcel</artifactId>
<version>${project.version}</version>
<version>0.16.0-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>org.dhatim</groupId>
<artifactId>fastexcel-reader</artifactId>
<version>${project.version}</version>
<version>0.16.0-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>org.apache.logging.log4j</groupId>
Expand Down