-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup Maven #276
base: master
Are you sure you want to change the base?
Cleanup Maven #276
Conversation
@@ -4,17 +4,13 @@ | |||
<parent> | |||
<groupId>org.dhatim</groupId> | |||
<artifactId>fastexcel-parent</artifactId> | |||
<version>0-SNAPSHOT</version> | |||
<version>0.16.0-SNAPSHOT</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this set during the publish process (and not updated via commit in the pom)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but it's not enough, I think.
It's set during the release process, but to be consistent into a Maven life cycle, it should evoluate into the master branch release after release.
The version change (x.x.x-SNAPSHOT -> x.x.x -> x.x+1.x-SNAPSHOT) plus tagging, commits and publishing is totally handled b the Maven Release plugin.
Thank you for your PR. Actually, we got some inspiration from this article and the goal was to have an efficient CI-compatible release process, not to have an "up to date" pom.xml in git. |
I understand. Should I continue to work on that, or should I drop the idea ? |
In my opinion, this is not a critical issue. It also depends on how much time you can spend on this topic. Maybe things changed since 2016 (c.f. the date of the last article from the series)... |
Okay, I'll have a look but not spend a lot of time and brain on it. |
It seems that GitHub has a packager Maven Release action https://github.com/qcastel/github-actions-maven-release |
I removed some maven variable and updated version numbers.
I purpose to use
mvn versions pluging
ormaven release plugin
in order to set dependencies version or release number and building.