Brewing Stands #916
Open
Brewing Stands #916
+720
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xNatsuri
commented
Sep 7, 2024
TwistedAsylumMC
requested changes
Nov 17, 2024
TwistedAsylumMC
approved these changes
Nov 17, 2024
DaPigGuy
requested changes
Nov 17, 2024
| // all these imports. This ensures that all items are registered before the creative items are registered | ||
| // in the init function in this package. | ||
| // The following four imports are essential for this package: They make sure this package is loaded after | ||
| // all these imports. This ensures that all blocks anditems are registered before the creative items are |
There was a problem hiding this comment.
Suggested change
| // all these imports. This ensures that all blocks anditems are registered before the creative items are | |
| // all these imports. This ensures that all blocks and items are registered before the creative items are |
Comment on lines
+42
to
+46
|
|
||
| // LightEmissionLevel ... | ||
| func (b BrewingStand) LightEmissionLevel() uint8 { | ||
| return 1 | ||
| } |
There was a problem hiding this comment.
Suggested change
| // LightEmissionLevel ... | |
| func (b BrewingStand) LightEmissionLevel() uint8 { | |
| return 1 | |
| } |
Brewing stands don't emit light on Bedrock
| // BreakInfo ... | ||
| func (b BrewingStand) BreakInfo() BreakInfo { | ||
| drops := b.inventory.Items() | ||
| drops = append(drops, item.NewStack(b, 1)) |
There was a problem hiding this comment.
It may be better to drop the inventory items in a break handler, similar to chests/furnaces
| if brewingSlot == 0 || brewingSlot == 4 || !brewingStack.Empty() { | ||
| continue | ||
| } | ||
| slot = brewingSlot |
There was a problem hiding this comment.
Missing validation here to make sure the item is usable in a brewing recipe
| } | ||
|
|
||
| if ok || okTwo { | ||
| _, containerChange := recipe.(PotionContainerChange) |
There was a problem hiding this comment.
containerChange and ok are equivalent
|
|
||
| if ok || okTwo { | ||
| _, containerChange := recipe.(PotionContainerChange) | ||
| inputItems2 := make([]world.Item, len(recipe.Input())) |
There was a problem hiding this comment.
Why is this named inputItems2?
DaPigGuy
reviewed
Nov 17, 2024
| } | ||
|
|
||
| // ValidBrewingReagent checks if the world.Item is a brewing reagent. | ||
| func ValidBrewingReagent(itemName string) bool { |
There was a problem hiding this comment.
Why not take a world.Item here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements brewing stands
Built off #632
Resolves #520