Clear login data #51
Clear login data #51
Conversation
| @@ -1,24 +1,25 @@ | |||
| $primary: #0059F7; | |||
There was a problem hiding this comment.
This was all from Prettier 😬 I think it helps with consistency and readability to have these changes
Apart from all the syntax updates, I removed the following styles and added them to log-in.component.scss since that's the only place they were being used
.log-in-google,
.log-in-seed,
.sign-up-google,
.sign-up-seed {
height: 72px;
width: 290px;
background-size: 290px 72px;
}
.log-in-google {
background-image: url(/assets/log_in_google.png);
}
.log-in-seed {
background-image: url(/assets/log_in_seed.png);
}
.sign-up-google {
background-image: url(/assets/sign_up_google.png);
}
.sign-up-seed {
background-image: url(/assets/sign_up_seed.png);
}
|
|
||
| .sign-up-seed { | ||
| background-image: url(/assets/sign_up_seed.png); | ||
| } |
There was a problem hiding this comment.
moved most of these over from styles.scss since they're only used for login
akutch
changed the title
akutch
changed the title
| class="container home-container" | ||
| *ngIf="globalVars.inTab || globalVars.webview" | ||
| > | ||
| <div class="font-weight-bold fs-30px mb-20px">Clear Login Data</div> |
There was a problem hiding this comment.
I changed the verbiage here from wipe --> clear since I felt like it reads and looks better. I can certainly change it back if we want to stick with wipe, though.
There was a problem hiding this comment.
I think "Clear" is a better choice here. Let's stick with your change.
| class="btn btn-primary font-weight-bold fs-15px ml-10px sign-up-btn" | ||
| [routerLink]="['/log-in']" | ||
| > | ||
| Confirm |
There was a problem hiding this comment.
I also changed this button text from Next --> Confirm to match the above "Confirming this step will.." phrasing
|
@akutch amazing! thank you so much. |
|
Any updates here? |
| class="container home-container" | ||
| *ngIf="globalVars.inTab || globalVars.webview" | ||
| > | ||
| <div class="font-weight-bold fs-30px mb-20px">Clear Login Data</div> |
There was a problem hiding this comment.
I think "Clear" is a better choice here. Let's stick with your change.
| class="btn btn-primary font-weight-bold fs-15px ml-10px sign-up-btn" | ||
| [routerLink]="['/log-in']" | ||
| > | ||
| Confirm |
| @@ -69,20 +64,16 @@ export class LogInComponent implements OnInit { | |||
| oauthUri.searchParams.append('client_id', GoogleDriveService.CLIENT_ID); | |||
| oauthUri.searchParams.append('scope', GoogleDriveService.DRIVE_SCOPE); | |||
| oauthUri.searchParams.append('response_type', 'token'); | |||
| // TODO: Investigate using this parameter to defend against CSRF attacks | |||
There was a problem hiding this comment.
Looks like a merge accident?
|
If you could just fix that one merge conflict I'd love to get this added |
Description
Based on @tijno's changes #39 per issue #34
Adds "Clear login data" option to login for users to be able to wipe their accounts from localstorage. The bulk of the diff here is from Prettier formatting the styles.scss file 😅
Screenshots