-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wipe login data #39
Wipe login data #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a quick read of the changes Everything LGTM -- Note though that I'm able to test this locally (as I broke my machine 😬), however I assume you've done so already based on the gif provided in #34.
This doesn't solve the major security concerns which Identity presents, but small additions like this definitely make things a bit easier for the end user. Thanks for the PR!
@tijno I'd like to make this a separate component e.g. /logout Which extensions were compromised? |
ok will make it separate component. not sure which ones - @HPaulson looked into that side of the hacked accounts. I could see about 20 likely affected. |
thank you! |
Has anyone provided any proof or identified specific extensions? Seemed like some opportunist FUD to me. "Someone sent all my CLOUT to an anon address." Please donate. 😂 |
I had so much loosing money then asking people in discord to help. Its laugh for you because you are not a from third world country. Laughing off people losses, what a shame. And mentioning as I asking for something that wasn't mine. |
@tijno if you have some time I'd love to get this merged |
ill do my best this weekend @maebeam
time to learn some angular. |
I might have time to split this out into a separate component this afternoon. I'll post here before I do just in case you get to it first @tijno |
earliest i will get to it is sunday @akutch this would be so amazing 🤩 |
yes separate component and i think separate route too as "signup" for example from memory is a separate route too. So keep consistent with that. |
The changes are ready for review here: #51 |
included in PR mentioned above by @akutch so closing this one. |
This is the PR as per issue #34
It will clear login info from local storage for all logged in accounts after the user enters a confirmation sentence.
cc @HPaulson