Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(.github/actions): add get-issue-url-and-version-number-v1 action #64

Closed
wants to merge 26 commits into from

Conversation

Zidious
Copy link
Contributor

@Zidious Zidious commented Oct 13, 2023

This PR add an action that gets the issue URL And version number from the release-candidate issue and e.g. use for posting slack notifications. Adding this small GHA here means it lives in once place as it will be added to 5+ repositories.

Example workflow file:https://github.com/dequelabs/zidious-testing/actions/runs/6696030017/workflow
Example workflow: https://github.com/dequelabs/zidious-testing/actions/runs/6696030017/job/18192888009

Closes: #63, #82

@Zidious Zidious marked this pull request as ready for review October 13, 2023 21:30
@Zidious Zidious requested a review from a team as a code owner October 13, 2023 21:30
@Zidious Zidious marked this pull request as draft October 17, 2023 23:38
@Zidious Zidious changed the title feat(.github/actions): add get-version-number-and-issue-url action feat(.github/actions): add get-issue-url-and-version-number-v1 action Oct 18, 2023
@Zidious Zidious marked this pull request as ready for review October 18, 2023 17:53
@Zidious Zidious requested a review from straker October 18, 2023 17:53
Copy link
Contributor

@straker straker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is small but I think this should be a typescript file and include tests. is-release-in-progress doesn't do too much more but does have tests.

This also doesn't need to be a composite action anymore as it only has the 1 step.

@Zidious
Copy link
Contributor Author

Zidious commented Nov 1, 2023

@straker
Copy link
Contributor

straker commented Nov 9, 2023

We are changing how we are doing this. Instead of opening the QA ticket from the create-release-candidate action, we'll be creating a new action that is run on push to release branch that will build and deploy the release, then we will create the QA ticket. Since we'll be in the branch that has all the information, we don't need to look for tickets and can just use the version from package.json and the current commit sha to put into the ticket.

@straker straker closed this Nov 9, 2023
@dequejenn dequejenn reopened this Nov 14, 2023
@dequejenn
Copy link

We do need this, as we are not creating the issue during this step. We are creating the issue in create-release-candidate and then adding a comment to it, moving the issue around, and sending to slack in deploy-release-candidate

@straker
Copy link
Contributor

straker commented Nov 21, 2023

Scope change:

  1. We don't need to get the version number. At any point we would call this we can just look at the version of package.json in the current repo
  2. For the docs repo there can be multiple open issues labeled release, either for different repos or even the same repo if multiple versions were released in quick succession and the docs for the prior one haven't been written yet. We'll need to filter all the open release issues by the name of the github repo and also by the current version. Allow supplying version number to input but default to current version from package.json
  3. We'll need to allow the action to get issues from other repos (namely the docs repo). Add input for repo (default to current context repo)
  4. Rename action to get-release-issue

Copy link
Contributor

@straker straker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(see prior comment)

@Zidious
Copy link
Contributor Author

Zidious commented Dec 4, 2023

Superseded by: #101

@Zidious Zidious closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make GHA pull latest version
3 participants