-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(.github/actions): add get-issue-url-and-version-number-v1
action
#64
Conversation
get-version-number-and-issue-url
actionget-issue-url-and-version-number-v1
action
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is small but I think this should be a typescript file and include tests. is-release-in-progress
doesn't do too much more but does have tests.
This also doesn't need to be a composite action anymore as it only has the 1 step.
… into feat-get-version-number-and-issue-url
.github/actions/get-issue-url-and-version-number-v1/src/run.test.ts
Outdated
Show resolved
Hide resolved
.github/actions/get-issue-url-and-version-number-v1/src/run.test.ts
Outdated
Show resolved
Hide resolved
Re-ran test worflow: https://github.com/dequelabs/zidious-testing/actions/runs/6721071926/job/18265974025 |
We are changing how we are doing this. Instead of opening the QA ticket from the create-release-candidate action, we'll be creating a new action that is run on push to |
We do need this, as we are not creating the issue during this step. We are creating the issue in |
Scope change:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(see prior comment)
Superseded by: #101 |
This PR add an action that gets the issue URL And version number from the release-candidate issue and e.g. use for posting slack notifications. Adding this small GHA here means it lives in once place as it will be added to 5+ repositories.
Example workflow file:https://github.com/dequelabs/zidious-testing/actions/runs/6696030017/workflow
Example workflow: https://github.com/dequelabs/zidious-testing/actions/runs/6696030017/job/18192888009
Closes: #63, #82