Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(.github/actions): add get-release-issue-v1 action #101

Merged
merged 14 commits into from
Dec 13, 2023

Conversation

Zidious
Copy link
Contributor

@Zidious Zidious commented Dec 4, 2023

This PR adds a new GHA for getting a issue URL for a given repo and version number.

  • The input version is required and is likely going to be part of a composite action to grab the version from package.json (for example) and passed to this action
  • The input owner-and-repo can be overridden to something like dequelabs/my-repo but defaults to current repo
  • Added tests accordingly

Internal-testing:

Given a single issue: https://github.com/dequelabs/zidious-testing/actions/runs/7090495379/job/19297573314
Given multiple issues and repos: https://github.com/dequelabs/zidious-testing/actions/runs/7090546614/job/19297744680
Given the issue doesn't exist: https://github.com/dequelabs/zidious-testing/actions/runs/7090586377/job/19297887126
Given an unknown owner-and-repo input: https://github.com/dequelabs/zidious-testing/actions/runs/7090579202/job/19297860895

Ref: #64 (comment)
Closes: #82

straker
straker previously requested changes Dec 6, 2023
.github/actions/get-release-issue-v1/README.md Outdated Show resolved Hide resolved
.github/actions/get-release-issue-v1/action.yml Outdated Show resolved Hide resolved
.github/actions/get-release-issue-v1/src/run.ts Outdated Show resolved Hide resolved
.github/actions/get-release-issue-v1/src/run.ts Outdated Show resolved Hide resolved
.github/actions/get-release-issue-v1/src/run.ts Outdated Show resolved Hide resolved
.github/actions/get-release-issue-v1/src/run.ts Outdated Show resolved Hide resolved
.github/actions/get-release-issue-v1/src/run.test.ts Outdated Show resolved Hide resolved
.github/actions/get-release-issue-v1/src/run.test.ts Outdated Show resolved Hide resolved
.github/actions/get-release-issue-v1/src/run.ts Outdated Show resolved Hide resolved
straker
straker previously requested changes Dec 7, 2023
Copy link
Contributor

@straker straker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. This looks a lot better and a lot simpler.

One final test to add is the test of the top-level try/catch.

.github/actions/get-release-issue-v1/src/run.test.ts Outdated Show resolved Hide resolved
.github/actions/get-release-issue-v1/src/run.test.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@straker straker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit in a test description

.github/actions/get-release-issue-v1/src/run.test.ts Outdated Show resolved Hide resolved
@Zidious Zidious merged commit 4973b0f into main Dec 13, 2023
13 checks passed
@Zidious Zidious deleted the feat-add-release-issue-acton branch December 13, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create public action get-release-issue
2 participants