-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(.github/actions): add get-release-issue-v1
action
#101
Conversation
Test workflows - When the issue doesn't exist: https://github.com/dequelabs/zidious-testing/actions/runs/7119956090/job/19386169053 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. This looks a lot better and a lot simpler.
One final test to add is the test of the top-level try/catch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small nit in a test description
Co-authored-by: Steven Lambert <[email protected]>
This PR adds a new GHA for getting a issue URL for a given repo and version number.
version
is required and is likely going to be part of a composite action to grab the version from package.json (for example) and passed to this actionowner-and-repo
can be overridden to something likedequelabs/my-repo
but defaults to current repoInternal-testing:
Given a single issue: https://github.com/dequelabs/zidious-testing/actions/runs/7090495379/job/19297573314
Given multiple issues and repos: https://github.com/dequelabs/zidious-testing/actions/runs/7090546614/job/19297744680
Given the issue doesn't exist: https://github.com/dequelabs/zidious-testing/actions/runs/7090586377/job/19297887126
Given an unknown
owner-and-repo
input: https://github.com/dequelabs/zidious-testing/actions/runs/7090579202/job/19297860895Ref: #64 (comment)
Closes: #82