[issue-4] - Fix accesibility issues AutoSuggest address component #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add locatie on desktop Change styling and remove no container found on map functionality. * Add dynamic text desktop on detailpanel * Change language properties * Change old comment * Add deprecation message
* Refactor FilterForm to TS * Refactor FilterForm test to TS * Fix failing tests * Added some more types
Changed "U kunt dit formulier niet verder invullen. Lees in de rode tekst hieronder waar u uw melding wél kunt doen." to "U kunt dit formulier niet verder invullen. Lees onder de antwoorden waar u uw melding wel kunt doen."
… form (Amsterdam#2739) Implement useWatch FormValues are not always updated because Detail is not always rendered anew. After 3 clicks a bug appears. Therefor implemented useWatch, so updates are monitored and only the effected component is rerendered
* Create accordion component * Implement in CheckboxGroup * Implement in radiobuttons and category group * Implement in CategoryGroups * Add accordion styling * Add page styling * Fix double title * Add SPDX * Show count when pre-selected main category * Resolved PR feedback * Adjsut tests * Add tests accordion
also changed Standaardteksten per status to Standaardteksten volgorde.
Only users with permission add_attachment will see the button Bestand toevoegen Only users with permission change_attachment will see the edit icon. Permissions change_attachment and add_attachment are added to permissions for Attachments Permissions are moved to constants file in IncidentDetail directory.
…#2750) * Change label color with newDesignDystem prop * PR feedback
* Fetch standard texts correctly * Return null when standardTexts are undefined * PR feedback
…efresh icon. (Amsterdam#2752) Since this is a bug in prod, transforming IncidentOverviewTitle to tsx will have a separate PR.
…msterdam#2754) * Order incident table with headers instead of dropdown Order by clicking header Put sort icon in own folder Extract Th component to own component Styling table header Add Chevron svg instead of string value * Add requested changes * Fix test * Add small change * Add element type
* Put search bar to top menu * Change tests * Fix test coverage * PR feedback * PR feedback
…osuggest is tested for dealing with changes, it does not need to be also tested in FilterForm.test (Amsterdam#2758) serviceParams as props for PDOKAutosuggest
… and screen-only class
show objects in list view, make clickable and show selectable objects: * Change folders * Add detail panel tests * Add IconList test * Fix max asset warning when selection is empty * Fix jumping to location when there's one allready * Test useSelectionProps * When zoom threshold is not reached, dont show detailpanel on mobile
… check if address is filled in or not
… and screen-only class
… check if address is filled in or not
…-select' into fix-accesibility-issues-address-select # Conflicts: # src/signals/incident/components/form/MapSelectors/Asset/Selector_v2_removeafterfinishepic5440/DetailPanel/DetailPanel.tsx # src/signals/incident/components/form/MapSelectors/Asset/Selector_v2_removeafterfinishepic5440/Selector.tsx
…-select' into fix-accesibility-issues-address-select # Conflicts: # src/signals/incident/components/form/MapSelectors/Asset/Selector_v2_removeafterfinishepic5440/Selector.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: issue 4
Signalen
Before opening a pull request, please ensure:
mainand targetsmainBe kind to code reviewers, please try to keep pull requests as small and focused as possible :)