-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] [Kernel]Make kernel lib suit the standalone. #3171
Closed
horizonzy
wants to merge
11
commits into
delta-io:master
from
horizonzy:upgrade-kernel-to-suit-standalone
Closed
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
018d536
make kernel lib suit the standalone.
horizonzy 12ebd96
Fix update schema failed problem.
horizonzy 7272394
Fix ci.
horizonzy 663664f
Fix ci.
horizonzy 13e8419
fix ci.
horizonzy 47a8342
Introduce expired log clean.
horizonzy 9296686
Fix log clean bug.
horizonzy f928ce3
Reduce unnecessary metadata updating.
horizonzy 18fd8b0
Fix ci.
horizonzy 2887210
fix ci.
horizonzy 0175ed2
fix ci.
horizonzy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -77,4 +77,6 @@ CloseableIterator<ByteArrayInputStream> readFiles( | |
* @throws IOException for any IO error. | ||
*/ | ||
boolean mkdirs(String path) throws IOException; | ||
|
||
boolean delete(String path) throws IOException; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This interface method and its default implementation can be a separate PR. |
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -60,6 +60,31 @@ public class TableConfig<T> { | |
"needs to be a positive integer." | ||
); | ||
|
||
public static final TableConfig<Long> LOG_RETENTION = new TableConfig<>( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These can be added in a separate PR. |
||
"delta.logRetentionDuration", | ||
"interval 30 days", | ||
IntervalParserUtils::safeParseIntervalAsMillis, | ||
value -> true, | ||
"needs to be provided as a calendar interval such as '2 weeks'. Months " | ||
+ "and years are not accepted. You may specify '365 days' for a year instead." | ||
); | ||
|
||
public static final TableConfig<Boolean> ENABLE_EXPIRED_LOG_CLEANUP = new TableConfig<>( | ||
"delta.enableExpiredLogCleanup", | ||
"true", | ||
Boolean::valueOf, | ||
value -> true, | ||
"needs to be a boolean." | ||
); | ||
|
||
public static final TableConfig<Boolean> IS_APPEND_ONLY = new TableConfig<>( | ||
"delta.appendOnly", | ||
"false", | ||
Boolean::valueOf, | ||
value -> true, | ||
"needs to be a boolean." | ||
); | ||
|
||
private final String key; | ||
private final String defaultValue; | ||
private final Function<String, T> fromString; | ||
|
@@ -79,6 +104,10 @@ private TableConfig( | |
this.helpMessage = helpMessage; | ||
} | ||
|
||
public String key() { | ||
return key; | ||
} | ||
|
||
/** | ||
* Returns the value of the table property from the given metadata. | ||
* | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make the code cleanup here as a separate PR.