[WIP] [Kernel]Make kernel lib suit the standalone. #3171
Conversation
There was a problem hiding this comment.
Hi @horizonzy, Thanks for this PR. Overall it has lot of pieces in it. I commented on the few code pointers which can be extracted out into separate PRs.
| @@ -92,24 +93,7 @@ public String getString(int rowId) { | |||
| } | |||
| }, | |||
| Optional.ofNullable(1234L), | |||
| new MapValue() { // conf | |||
There was a problem hiding this comment.
make the code cleanup here as a separate PR.
| @@ -77,4 +77,6 @@ CloseableIterator<ByteArrayInputStream> readFiles( | |||
| * @throws IOException for any IO error. | |||
| */ | |||
| boolean mkdirs(String path) throws IOException; | |||
|
|
|||
| boolean delete(String path) throws IOException; | |||
There was a problem hiding this comment.
This interface method and its default implementation can be a separate PR.
|
|
||
| // TODO: handle the legacy 2-level list physical format | ||
| checkArgument(repeatedGroup.getFieldCount() == 1, | ||
| Type type = typeFromFile.getType(0); |
There was a problem hiding this comment.
Is this supporting a legacy list formats? If yes, I think there are more cases to handle. Also checkout the ParquetFielReaderSuite.scala (read parquet file generated by parquet-thrift) for disabled tests which can be enabled once this is fixed.
Also this can be a separate PR.
There was a problem hiding this comment.
Yes, here I just make a patch to work around the issue. We can open a new issue to trace the problem, I will attach the test table, it's easy to reproduce the issue.
| @@ -60,6 +60,31 @@ public class TableConfig<T> { | |||
| "needs to be a positive integer." | |||
| ); | |||
|
|
|||
| public static final TableConfig<Long> LOG_RETENTION = new TableConfig<>( | |||
There was a problem hiding this comment.
These can be added in a separate PR.
No description provided.