Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mapbox hpp skel #6

Merged
merged 22 commits into from
Sep 12, 2018
Merged

Use mapbox hpp skel #6

merged 22 commits into from
Sep 12, 2018

Conversation

delfrrr
Copy link
Owner

@delfrrr delfrrr commented Sep 9, 2018

Based on PR from @flippmoke #3

  • plus fixing builds
  • plus removing (for now) coverage and code style check facilities

@delfrrr delfrrr changed the title Updated to use mapbox hpp skel Use mapbox hpp skel Sep 9, 2018
@delfrrr delfrrr mentioned this pull request Sep 9, 2018
@delfrrr
Copy link
Owner Author

delfrrr commented Sep 10, 2018

@flippmoke what was the motivation to change Delaunator class to struct?

@flippmoke
Copy link
Contributor

@delfrrr the original thought was to make it a struct and then simply migrate over time the methods to act on it instead of acting on private values within the struct. The reason for this was that there is very limited information that is actually required at the end and some variables are just needed within the struct itself. If you wish to make it back into a class that is fine, but I think currently the struct stores too much extra information that isn't required after the algorithm is run.

@delfrrr
Copy link
Owner Author

delfrrr commented Sep 11, 2018

@flippmoke ah so you suggest instead of using private properties pass them as references to the parameters of the methods? and move methods to static functions? so at the end it can be just a static function which returns struct with triangles and half-edges?

I think It's not bad idea; but it's also true for JS version (cc @mourner); I'm trying to keep close to JS version so I can move updates to cpp version.

I added separate issue #7 for this. For now having struct with private members does not make sense for me.

@delfrrr
Copy link
Owner Author

delfrrr commented Sep 11, 2018

@flippmoke any particular reason for std::vector<double> const& coords instead of const std::vector<double> &coords?

@delfrrr delfrrr merged commit 5ba668d into master Sep 12, 2018
@delfrrr delfrrr deleted the layout-updates branch September 12, 2018 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants