parity with js version #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
morishuz
commented
Sep 8, 2018
•
morishuz
commented
- added important changes from new js version to cpp
- removed issue with std::move. coords is now just an argument: simpler and safer.
- simplified sorting (helped with previous point)
- added tests to compare 5000 vertex triangulation with new js version
…nged sort to use lambda which simplifies const coord passing.
mourner
reviewed
Sep 8, 2018
src/delaunator.cpp
Outdated
| e = m_hull[e].next; | ||
| while(!orient(x, y,m_hl[e].x, m_hl[e].y,m_hl[m_hl[e].next].x, m_hl[m_hl[e].next].y)) | ||
| { | ||
| e = m_hl[e].next; | ||
|
|
||
| if (e == start) { | ||
| throw runtime_error("Something is wrong with the input points."); |
There was a problem hiding this comment.
This place is different in JS — let's port over the fix here too.
There was a problem hiding this comment.
very good, i missed that. fixed now
src/delaunator.cpp
Outdated
| const long int n = coords.size() >> 1; | ||
| Delaunator::Delaunator() | ||
| { | ||
| m_epilon = std::pow(2,-52); |
|
@morishuz thank you for PR! Unfortunately I have to suggest to close it:
|
|
Already fixed by other commits, see #2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.