Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Types and tmp caching #91

Merged
merged 5 commits into from
Aug 8, 2024
Merged

refactor: Types and tmp caching #91

merged 5 commits into from
Aug 8, 2024

Conversation

bmingles
Copy link
Collaborator

@bmingles bmingles commented Aug 8, 2024

Refactored a few things

  • Fixed base DhService + constructor type in preparation for DHE support
  • Installed @deephaven/jsapi-types and deleted shim types
  • Tweaked tmp storage to store to src/dist root and to store jsapi by server url
  • Enabled no-unused-vars linting rule

supports #79

Copy link

github-actions bot commented Aug 8, 2024

End-to-end Test Summary

Tests 📝Passed ✅Failed ❌Skipped ⏭️Pending ⏳Other ❓Flaky 🍂Duration ⏱️
330000001:59:45
A ctrf plugin

Detailed Test Results

NameStatusmsFlaky 🍂
should be able to load VSCodepassed ✅951
should only be visible when a supported file type is active: test.groovypassed ✅2948
should only be visible when a supported file type is active: test.pypassed ✅1097
A ctrf plugin

Failed Test Summary

No failed tests ✨

Flaky Test Summary

No flaky tests detected. ✨

Copy link

github-actions bot commented Aug 8, 2024

Unit Test Summary

Tests 📝Passed ✅Failed ❌Skipped ⏭️Pending ⏳Other ❓Flaky 🍂Duration ⏱️
17170000000:00:00
A ctrf plugin

Detailed Test Results

NameStatusmsFlaky 🍂
src/services/Config.spec.ts: Config > should return core servers: Empty configpassed ✅3
src/services/Config.spec.ts: Config > should return core servers: String configpassed ✅0
src/services/Config.spec.ts: Config > should return core servers: Default urlpassed ✅0
src/services/Config.spec.ts: Config > should return core servers: Full configpassed ✅2
src/util/ExtendedMap.spec.ts: ExtendedMap Test Suite > getOrThrowpassed ✅2
src/util/downloadUtils.spec.ts: getTempDir > should create temp directory if it does not already exist: true, undefinedpassed ✅4
src/util/downloadUtils.spec.ts: getTempDir > should create temp directory if it does not already exist: true, subDirectorypassed ✅1
src/util/downloadUtils.spec.ts: getTempDir > should create temp directory if it does not already exist: false, undefinedpassed ✅1
src/util/downloadUtils.spec.ts: getTempDir > should create temp directory if it does not already exist: false, subDirectorypassed ✅1
src/util/downloadUtils.spec.ts: getTempDir > should remove directory if recreate is true: true, undefined, /home/runner/work/vscode-deephaven/vscode-deephaven/src/tmppassed ✅2
src/util/downloadUtils.spec.ts: getTempDir > should remove directory if recreate is true: true, subDirectory, /home/runner/work/vscode-deephaven/vscode-deephaven/src/tmp/subDirectorypassed ✅1
src/util/downloadUtils.spec.ts: getTempDir > should remove directory if recreate is true: false, undefined, /home/runner/work/vscode-deephaven/vscode-deephaven/src/tmppassed ✅1
src/util/downloadUtils.spec.ts: getTempDir > should remove directory if recreate is true: false, subDirectory, /home/runner/work/vscode-deephaven/vscode-deephaven/src/tmp/subDirectorypassed ✅0
src/util/urlUtils.spec.ts: urlUtils > should convert url to host_port string: http://localhost:4000, localhost_4000passed ✅2
src/util/urlUtils.spec.ts: urlUtils > should convert url to host_port string: https://localhost:5000, localhost_5000passed ✅2
src/util/urlUtils.spec.ts: urlUtils > should convert url to host_port string: http://www.acme.com:6000, www_acme_com_6000passed ✅0
src/util/urlUtils.spec.ts: urlUtils > should convert url to host_port string: https://www.acme.com:7000, www_acme_com_7000passed ✅0
A ctrf plugin

Failed Test Summary

No failed tests ✨

Flaky Test Summary

No flaky tests detected. ✨

@bmingles bmingles merged commit 57b3597 into main Aug 8, 2024
3 checks passed
@bmingles bmingles deleted the 79-3-types-and-tmp-cache branch August 8, 2024 17:21
@bmingles bmingles linked an issue Aug 8, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetch DHE js api from server
1 participant