Skip to content

Commit

Permalink
refactor: Types and tmp caching (#91)
Browse files Browse the repository at this point in the history
Refactored a few things
- Fixed base DhService + constructor type in preparation for DHE support
- Installed @deephaven/jsapi-types and deleted shim types
- Tweaked tmp storage to store to src/dist root and to store jsapi by
server url
- Enabled `no-unused-vars` linting rule

supports #79
  • Loading branch information
bmingles authored Aug 8, 2024
1 parent 63ecaed commit 57b3597
Show file tree
Hide file tree
Showing 15 changed files with 152 additions and 3,775 deletions.
1 change: 1 addition & 0 deletions .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
"eqeqeq": ["warn", "always", { "null": "ignore" }],
"no-console": "warn",
"no-throw-literal": "warn",
"no-unused-vars": ["error", { "argsIgnorePattern": "^_" }],
"semi": "off"
},
"overrides": [
Expand Down
13 changes: 13 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@
}
},
"devDependencies": {
"@deephaven/jsapi-types": "^1.0.0-dev0.35.3",
"@types/node": "20.14.10",
"@types/vscode": "^1.91.0",
"@types/ws": "^8.5.10",
Expand Down
4 changes: 4 additions & 0 deletions src/common/constants.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import * as path from 'node:path';

export const CONFIG_KEY = 'vscode-deephaven';
export const CONFIG_CORE_SERVERS = 'core-servers';

Expand All @@ -17,3 +19,5 @@ export const DOWNLOAD_LOGS_TEXT = 'Download Logs';
export const SERVER_LANGUAGE_SET = new Set(['python', 'groovy']) as ReadonlySet<
'python' | 'groovy'
>;

export const TMP_DIR_ROOT = path.join(__dirname, '..', 'tmp');
Loading

0 comments on commit 57b3597

Please sign in to comment.