Don't add measure-level filters to post-agg filters #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamDee
requested review from
courtneyholcomb,
serramatutu,
DevonFulcher and
theyostalservice
WilliamDee
commented
Oct 9, 2024
| ON | ||
| subq_15.ds = subq_13.metric_time__day | ||
| ) subq_16 | ||
| WHERE metric_time__day > '2020-01-01' |
There was a problem hiding this comment.
booking__is_instant measure-level filter is not applied here
...ntics/metricflow_semantics/test_helpers/semantic_manifest_yamls/simple_manifest/metrics.yaml
Outdated
Show resolved
Hide resolved
...ntics/metricflow_semantics/test_helpers/semantic_manifest_yamls/simple_manifest/metrics.yaml
Show resolved
Hide resolved
courtneyholcomb
force-pushed
the
court/ts-filter-fix
branch
3 times, most recently
from
a3e07bf
to
2affb6d
Compare
WilliamDee
force-pushed
the
will/filter-hierarchy
branch
2 times, most recently
from
de0a385
to
b21dc21
Compare
courtneyholcomb
approved these changes
Oct 11, 2024
metricflow-semantics/metricflow_semantics/specs/where_filter/where_filter_spec_set.py
Outdated
Show resolved
Hide resolved
metricflow-semantics/metricflow_semantics/specs/where_filter/where_filter_spec_set.py
Show resolved
Hide resolved
|
After rebasing and adding the check query tests, can you run the SQL engine tests on this PR too? |
WilliamDee
force-pushed
the
will/filter-hierarchy
branch
from
548ba21
to
87c62a6
Compare
WilliamDee
force-pushed
the
will/filter-hierarchy
branch
from
87c62a6
to
4b35f88
Compare
WilliamDee
added
the
Run Tests With Other SQL Engines
WilliamDee
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
WilliamDee
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
WilliamDee
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
WilliamDee
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
github-actions
bot
removed
the
Run Tests With Other SQL Engines
Merged
WilliamDee
added a commit
that referenced
this pull request
Oct 15, 2024
## Context After merging #1452, seems like snapshots in MF-semantics were missing (CI still passed - odd). But updated those and also updated the script to update snapshots in MF semantics as that seems to be missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We should respect filter hierarchy and have,
Meaning, measure-level filters should not be applied post-aggregation.
Refactor
Changed
filter_specsfrom being a tuple of filter specs all mashed together to aWhereFilterSpecSetwhere it stores which levels each of the filters were defined at. This was changed insideMetricSpecandMetricInputMeasureSpec.Resolves SL-2956