Fix missing snapshots #1456
Merged
Fix missing snapshots #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamDee
force-pushed
the
will/fix-snapshots
branch
from
d8781dc
to
2dbc0ad
Compare
WilliamDee
commented
Oct 15, 2024
|
|
||
| # Run snapshots changes for metricflow-semantics | ||
| # these are not dialect specific, so only need to run once | ||
| run_command(f"pytest -x -vv -n 4 --overwrite-snapshots {MF_SEMANTICS_TEST_DIRECTORY}") |
There was a problem hiding this comment.
put this to be ran under the duckdb engine only, as we only need to run these updates once since it's not dialect specific
There was a problem hiding this comment.
Did you test this to make sure it works as expected?
courtneyholcomb
approved these changes
Oct 15, 2024
|
|
||
| # Run snapshots changes for metricflow-semantics | ||
| # these are not dialect specific, so only need to run once | ||
| run_command(f"pytest -x -vv -n 4 --overwrite-snapshots {MF_SEMANTICS_TEST_DIRECTORY}") |
There was a problem hiding this comment.
Did you test this to make sure it works as expected?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
After merging #1452, seems like snapshots in MF-semantics were missing (CI still passed - odd). But updated those and also updated the script to update snapshots in MF semantics as that seems to be missing.