Use list for where filters #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneyholcomb
force-pushed
the
court/ts-filter-fix
branch
from
df66cc9
to
366ff66
Compare
courtneyholcomb
changed the title
WilliamDee
force-pushed
the
court/ts-filter-fix
branch
from
366ff66
to
5944a67
Compare
courtneyholcomb
force-pushed
the
court/ts-filter-fix
branch
from
ae9ed58
to
d9d4b31
Compare
courtneyholcomb
force-pushed
the
court/ts-filter-fix
branch
from
d9d4b31
to
a3e07bf
Compare
courtneyholcomb
force-pushed
the
court/ts-filter-fix
branch
from
a3e07bf
to
2affb6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
There's a bug where time filters is not being re-applied after joining to timespine. Currently, we take all filter strings in a list of filters and mash them together. We need to keep them separate so that we can differentiate metric_time filters.
Resolves SL-2955