Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add dbt show tests #779

Merged
merged 8 commits into from
Sep 28, 2023
Merged

add dbt show tests #779

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2adac33
add dbt show tests
MichelleArk Sep 18, 2023
7b8dbc2
changelog entry
MichelleArk Sep 25, 2023
f406010
Merge branch 'main' into test-limit-in-show-sql
MichelleArk Sep 25, 2023
6e11bff
Merge branch 'main' into test-limit-in-show-sql
McKnight-42 Sep 28, 2023
c61c052
repoint to core main
McKnight-42 Sep 28, 2023
669e6df
reuse core fixture for dbt show sql header test
MichelleArk Sep 28, 2023
958804f
point to @improve-show-fixture dbt-core branch
MichelleArk Sep 28, 2023
7170441
undo dev-requirements changes
MichelleArk Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Under the Hood-20230925-144814.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Under the Hood
body: Add tests for inlined limit + sql_header in dbt show query
time: 2023-09-25T14:48:14.663178+01:00
custom:
Author: michelleark
Issue: "786"
4 changes: 2 additions & 2 deletions dev-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# install latest changes in dbt-core
# TODO: how to automate switching from develop to version branches?
git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-core&subdirectory=core
git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-tests-adapter&subdirectory=tests/adapter
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will undo before merging

git+https://github.com/dbt-labs/dbt-core.git@8496/limit-in-show-query#egg=dbt-core&subdirectory=core
git+https://github.com/dbt-labs/dbt-core.git@8496/limit-in-show-query#egg=dbt-tests-adapter&subdirectory=tests/adapter

# if version 1.x or greater -> pin to major version
# if version 0.x -> pin to minor
Expand Down
27 changes: 27 additions & 0 deletions tests/functional/adapter/dbt_show/test_dbt_show.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
import pytest
from dbt.tests.adapter.dbt_show.test_dbt_show import BaseShowSqlHeader, BaseShowLimit


my_model_sql_header_sql = """
{{
config(
materialized = "table"
)
}}
{% call set_sql_header(config) %}
SET MY_VARIABLE='test';
{% endcall %}
SELECT $MY_VARIABLE as column_name
"""


class TestBigQueryShowLimit(BaseShowLimit):
pass


class TestBigQueryShowSqlHeader(BaseShowSqlHeader):
@pytest.fixture(scope="class")
def models(self):
return {
"sql_header.sql": my_model_sql_header_sql,
}