Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add dbt show tests #779

Merged
merged 8 commits into from
Sep 28, 2023
Merged

add dbt show tests #779

merged 8 commits into from
Sep 28, 2023

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Sep 18, 2023 •
edited
Loading

resolves #786
docs dbt-labs/docs.getdbt.com/# n/a

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Sep 18, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

@MichelleArk MichelleArk mentioned this pull request Sep 18, 2023
Merged
4 tasks
@MichelleArk MichelleArk marked this pull request as ready for review September 25, 2023 14:03
@MichelleArk MichelleArk requested a review from a team as a code owner September 25, 2023 14:03
MichelleArk
MichelleArk commented Sep 25, 2023
View reviewed changes
dev-requirements.txt Outdated
@@ -1,7 +1,7 @@
# install latest changes in dbt-core
# TODO: how to automate switching from develop to version branches?
git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-core&subdirectory=core
git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-tests-adapter&subdirectory=tests/adapter
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will undo before merging

@MichelleArk MichelleArk mentioned this pull request Sep 28, 2023
Merged
5 tasks
@colin-rogers-dbt colin-rogers-dbt merged commit 658e16e into main Sep 28, 2023
24 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the test-limit-in-show-sql branch September 28, 2023 18:54
github-actions bot pushed a commit that referenced this pull request Sep 28, 2023
@MichelleArk @github-actions
add dbt show tests (#779)
1fad2c5 
* add dbt show tests

* changelog entry

* repoint to core main

* reuse core fixture for dbt show sql header test

* point to @improve-show-fixture dbt-core branch

* undo dev-requirements changes

---------

Co-authored-by: Matthew McKnight <[email protected]>
Co-authored-by: Matthew McKnight <[email protected]>
(cherry picked from commit 658e16e)
This was referenced Sep 28, 2023
Merged
Merged
github-actions bot pushed a commit that referenced this pull request Sep 28, 2023
@MichelleArk @github-actions
add dbt show tests (#779)
d25351f 
* add dbt show tests

* changelog entry

* repoint to core main

* reuse core fixture for dbt show sql header test

* point to @improve-show-fixture dbt-core branch

* undo dev-requirements changes

---------

Co-authored-by: Matthew McKnight <[email protected]>
Co-authored-by: Matthew McKnight <[email protected]>
(cherry picked from commit 658e16e)
McKnight-42 pushed a commit that referenced this pull request Sep 28, 2023
@github-actions @MichelleArk
add dbt show tests (#779) (#793)
4c64b17 
* add dbt show tests

* changelog entry

* repoint to core main

* reuse core fixture for dbt show sql header test

* point to @improve-show-fixture dbt-core branch

* undo dev-requirements changes

---------

Co-authored-by: Matthew McKnight <[email protected]>
Co-authored-by: Matthew McKnight <[email protected]>
(cherry picked from commit 658e16e)

Co-authored-by: Michelle Ark <[email protected]>
McKnight-42 pushed a commit that referenced this pull request Sep 28, 2023
@github-actions @MichelleArk
add dbt show tests (#779) (#792)
a28a728 
* add dbt show tests

* changelog entry

* repoint to core main

* reuse core fixture for dbt show sql header test

* point to @improve-show-fixture dbt-core branch

* undo dev-requirements changes

---------

Co-authored-by: Matthew McKnight <[email protected]>
Co-authored-by: Matthew McKnight <[email protected]>
(cherry picked from commit 658e16e)

Co-authored-by: Michelle Ark <[email protected]>
philippe-boyd-maxa pushed a commit to maxa-ai/dbt-snowflake that referenced this pull request Nov 27, 2023
@MichelleArk @McKnight-42 @philippe-boyd-maxa
add dbt show tests (dbt-labs#779)
c954c8a 
* add dbt show tests

* changelog entry

* repoint to core main

* reuse core fixture for dbt show sql header test

* point to @improve-show-fixture dbt-core branch

* undo dev-requirements changes

---------

Co-authored-by: Matthew McKnight <[email protected]>
Co-authored-by: Matthew McKnight <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McKnight-42 McKnight-42 McKnight-42 approved these changes

@mikealfare mikealfare Awaiting requested review from mikealfare mikealfare is a code owner automatically assigned from dbt-labs/adapters

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ADAP-916] [Tests] Add tests for inlined limit + sql_header in dbt show query
3 participants
@MichelleArk @McKnight-42 @colin-rogers-dbt