Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update is_dyanmic check for new accpetable value after snowflake bundle change 2024_03 #1020

Closed
wants to merge 4 commits into from
Closed

Update is_dyanmic check for new accpetable value after snowflake bundle change 2024_03 #1020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
12bf558
update is_dynamic check for new default value but leaving old as acce…
McKnight-42 May 6, 2024
878a1ec
add changelog
McKnight-42 May 6, 2024
8834f53
update query
McKnight-42 May 6, 2024
3d78183
case fixing
McKnight-42 May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changes/unreleased/Fixes-20240506-132648.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
kind: Fixes
body: update is_dynamic values to be in line with accepted values post 2024_03 sonwflake
change bundle
time: 2024-05-06T13:26:48.498776-05:00
custom:
Author: McKnight-42
Issue: "1016"
2 changes: 1 addition & 1 deletion dbt/include/snowflake/macros/catalog.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
table_schema as "table_schema",
table_name as "table_name",
case
when is_dynamic = 'YES' and table_type = 'BASE TABLE' THEN 'DYNAMIC TABLE'
when is_dynamic in ('YES', 'Y') and table_type = 'BASE TABLE' THEN 'DYNAMIC TABLE'
else table_type
end as "table_type",
comment as "table_comment",
Expand Down
2 changes: 1 addition & 1 deletion tests/functional/adapter/dynamic_table_tests/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ def query_relation_type(project, relation: SnowflakeRelation) -> Optional[str]:
sql = f"""
select
case
when table_type = 'BASE TABLE' and is_dynamic = 'YES' then 'dynamic_table'
when table_type = 'BASE TABLE' and is_dynamic in ('YES', 'Y') then 'dynamic_table'
when table_type = 'BASE TABLE' then 'table'
when table_type = 'VIEW' then 'view'
when table_type = 'EXTERNAL TABLE' then 'external_table'
Expand Down
Loading