Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update is_dyanmic check for new accpetable value after snowflake bundle change 2024_03 #1020

Closed
wants to merge 4 commits into from

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented May 6, 2024

resolves #1016
docs dbt-labs/docs.getdbt.com/#

Problem

https://docs.snowflake.com/en/release-notes/bcr-bundles/2024_03_bundle updates the is_dynamic field from YES to Y which we query to see if a table is a dynamic table for not.

this currently fails due to looking for different values from when the is_dynamic field was first introduced via #937

Solution

updating to check for both values for users pre and post change and updating same similar call in test

ISSUE:
we had to rebase this branch due to local repo getting corrupted leading to excessive amounts of extra commits that didn't mean or point to anything.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@McKnight-42 McKnight-42 self-assigned this May 6, 2024
@cla-bot cla-bot bot added the cla:yes label May 6, 2024
Copy link
Contributor

github-actions bot commented May 6, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

Copy link
Contributor

@mikealfare mikealfare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right. Any idea why there are 67 commits on this PR, dating back to last year though?

@VersusFacit
Copy link
Contributor

This PR is going to need to be rebased or something since it's way off main.

@McKnight-42
Copy link
Contributor Author

Closing as currently thoughts are that the real issue is around changes to show terse kind options for the bundle in question.

@McKnight-42 McKnight-42 closed this May 7, 2024
@mikealfare mikealfare deleted the mcknight/1016 branch July 17, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Dynamic tables with Snowflake change bundle 2024_03 results in dynamic table to issue
4 participants