-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CT-2888] Support dbt-semantic-interfaces 0.2.0 #8250
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QMalcolm
added
dependencies
Changes to the version of dbt dependencies
semantic
Issues related to the semantic layer
backport 1.6.latest
labels
Jul 28, 2023
QMalcolm
requested review from
emmyoop and
aranke
and removed request for
a team
July 28, 2023 20:55
Codecov Report
@@ Coverage Diff @@
## main #8250 +/- ##
==========================================
- Coverage 86.24% 86.22% -0.03%
==========================================
Files 174 174
Lines 25510 25515 +5
==========================================
- Hits 22002 22000 -2
- Misses 3508 3515 +7
|
4 tasks
QMalcolm
force-pushed
the
ct-2888--support-dsi-0.2.0
branch
from
July 28, 2023 21:14
2bbd647
to
2c6d0da
Compare
emmyoop
approved these changes
Jul 28, 2023
0.03% seems acceptable, moving forward with merging |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 1.6.latest
cla:yes
dependencies
Changes to the version of dbt dependencies
semantic
Issues related to the semantic layer
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #8247
Problem
There is a bug currently in core main and 1.6.latest where-in daemonic invocations of core get killed off due to a multi processing in DSI 0.1.0rc1. This is fixed in DSI 0.2.0 Additionally there are breaking changes in DSI 0.2.0 that we need to in core (and backported to core 1.6). This PR updates us to DSI 0.2.0 and includes the necessary changes to support it.
Solution
Checklist