Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2888] Support dbt-semantic-interfaces 0.2.0 #8250

Merged
merged 6 commits into from
Jul 28, 2023

Conversation

QMalcolm
Copy link
Contributor

resolves #8247

Problem

There is a bug currently in core main and 1.6.latest where-in daemonic invocations of core get killed off due to a multi processing in DSI 0.1.0rc1. This is fixed in DSI 0.2.0 Additionally there are breaking changes in DSI 0.2.0 that we need to in core (and backported to core 1.6). This PR updates us to DSI 0.2.0 and includes the necessary changes to support it.

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@QMalcolm QMalcolm added dependencies Changes to the version of dbt dependencies semantic Issues related to the semantic layer backport 1.6.latest labels Jul 28, 2023
@QMalcolm QMalcolm requested review from a team as code owners July 28, 2023 20:55
@QMalcolm QMalcolm requested review from emmyoop and aranke and removed request for a team July 28, 2023 20:55
@cla-bot cla-bot bot added the cla:yes label Jul 28, 2023
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #8250 (2c6d0da) into main (410506f) will decrease coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #8250      +/-   ##
==========================================
- Coverage   86.24%   86.22%   -0.03%     
==========================================
  Files         174      174              
  Lines       25510    25515       +5     
==========================================
- Hits        22002    22000       -2     
- Misses       3508     3515       +7     
Files Changed Coverage Δ
core/dbt/parser/schema_yaml_readers.py 90.69% <ø> (ø)
core/setup.py 0.00% <ø> (ø)
core/dbt/contracts/graph/nodes.py 94.46% <100.00%> (+0.02%) ⬆️
core/dbt/contracts/graph/unparsed.py 93.09% <100.00%> (+0.01%) ⬆️

... and 2 files with indirect coverage changes

@QMalcolm
Copy link
Contributor Author

0.03% seems acceptable, moving forward with merging

@QMalcolm QMalcolm merged commit 518eb73 into main Jul 28, 2023
49 of 50 checks passed
@QMalcolm QMalcolm deleted the ct-2888--support-dsi-0.2.0 branch July 28, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.6.latest cla:yes dependencies Changes to the version of dbt dependencies semantic Issues related to the semantic layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2888] Support DSI 0.2.0
2 participants