Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "state:modified vars, behind "state_modified_compare_vars" behaviour flag" (#10793) #10813

Merged
merged 7 commits into from
Oct 2, 2024
Merged

Revert "state:modified vars, behind "state_modified_compare_vars" behaviour flag" (#10793) #10813

merged 7 commits into from
Oct 2, 2024

Conversation

aranke
Copy link
Member

@aranke aranke commented Oct 2, 2024

Resolves #

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@cla-bot cla-bot bot added the cla:yes label Oct 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@aranke aranke added Skip Changelog Skips GHA to check for changelog file artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking labels Oct 2, 2024
@aranke aranke marked this pull request as ready for review October 2, 2024 18:53
@aranke aranke requested review from a team as code owners October 2, 2024 18:53
@aranke aranke requested review from wpowers-dbt and removed request for a team October 2, 2024 18:53
@codecov Codecov
Copy link

codecov bot commented Oct 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.12%. Comparing base (7940ad5) to head (8d69781).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10813      +/-   ##
==========================================
- Coverage   89.22%   89.12%   -0.10%     
==========================================
  Files         183      183              
  Lines       23457    23402      -55     
==========================================
- Hits        20930    20858      -72     
- Misses       2527     2544      +17
Flag Coverage Δ
integration 86.35% <93.75%> (-0.20%) ⬇️
unit 62.11% <43.75%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.11% <43.75%> (+0.01%) ⬆️
Integration Tests 86.35% <93.75%> (-0.20%) ⬇️

@aranke aranke merged commit 6b9c1da into main Oct 2, 2024
59 of 62 checks passed
@aranke aranke deleted the revert_10793 branch October 2, 2024 20:00
@ChenyuLInx ChenyuLInx mentioned this pull request Oct 3, 2024
Open
QMalcolm added a commit to dbt-labs/schemas.getdbt.com that referenced this pull request Oct 12, 2024
@QMalcolm
Add order_by and limit to v12 manifest
dd951ce 
Originally this work was done as part of #49.
However as they are additive fields that have a default values, they aren't
breaking changes. Thus here we're adding them to the v12 manifest. This is
in support of the currently open dbt-core PR dbt-labs/dbt-core#10532.

Note this also _drops_ the `vars` field from a few objects. It was originally added
to support changes in core (dbt-labs/dbt-core#10793). However,
those changes were reverted in core (dbt-labs/dbt-core#10813).
Since `vars` as a field never went out in a GA release of dbt-core, it is safe for us
to drop it.
@QMalcolm QMalcolm mentioned this pull request Oct 12, 2024
Merged
QMalcolm added a commit to dbt-labs/schemas.getdbt.com that referenced this pull request Oct 15, 2024
@QMalcolm
Add order_by and limit to v12 manifest
a23e9a9 
Originally this work was done as part of #49.
However as they are additive fields that have a default values, they aren't
breaking changes. Thus here we're adding them to the v12 manifest. This is
in support of the currently open dbt-core PR dbt-labs/dbt-core#10532.

Note this also _drops_ the `vars` field from a few objects. It was originally added
to support changes in core (dbt-labs/dbt-core#10793). However,
those changes were reverted in core (dbt-labs/dbt-core#10813).
Since `vars` as a field never went out in a GA release of dbt-core, it is safe for us
to drop it.
QMalcolm added a commit to dbt-labs/schemas.getdbt.com that referenced this pull request Oct 15, 2024
@QMalcolm
Add order_by and limit to v12 manifest (#65)
b5ff4af 
Originally this work was done as part of #49.
However as they are additive fields that have a default values, they aren't
breaking changes. Thus here we're adding them to the v12 manifest. This is
in support of the currently open dbt-core PR dbt-labs/dbt-core#10532.

Note this also _drops_ the `vars` field from a few objects. It was originally added
to support changes in core (dbt-labs/dbt-core#10793). However,
those changes were reverted in core (dbt-labs/dbt-core#10813).
Since `vars` as a field never went out in a GA release of dbt-core, it is safe for us
to drop it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gshank gshank gshank approved these changes

@wpowers-dbt wpowers-dbt Awaiting requested review from wpowers-dbt wpowers-dbt is a code owner automatically assigned from dbt-labs/cloud-artifacts

Assignees
No one assigned
Labels
artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aranke @gshank