Update v12 to have limit and order_by
#65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aranke
requested changes
Oct 14, 2024
We do want to unpublish v13 |
|
For others observing, we discussed over slack. I understood the comment as "are we sure we want to revert the creation of v13" when the question was really about "should this be 2 PRs". We're gonna split this into two PRs |
Originally this work was done as part of #49. However as they are additive fields that have a default values, they aren't breaking changes. Thus here we're adding them to the v12 manifest. This is in support of the currently open dbt-core PR dbt-labs/dbt-core#10532. Note this also _drops_ the `vars` field from a few objects. It was originally added to support changes in core (dbt-labs/dbt-core#10793). However, those changes were reverted in core (dbt-labs/dbt-core#10813). Since `vars` as a field never went out in a GA release of dbt-core, it is safe for us to drop it.
QMalcolm
force-pushed
the
qmalcolm--revert-v13-and-update-v12
branch
from
dd951ce
to
a23e9a9
Compare
aranke
approved these changes
Oct 15, 2024
QMalcolm
changed the title
limit and order_bylimit and order_by
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally adding
limitandorder_bywas done by #49, which added the v13 manifest. However, as these fields are additive and have default values, they aren't breaking changes. Thus, here we're adding them to the v12 manifest. This is in support of the currently open dbt-core PR dbt-labs/dbt-core#10532. Separately, v13 is being dropped by #66Note this also drops the
varsfield from a few objects. It was originally added to support changes in core (dbt-labs/dbt-core#10793). However, those changes were reverted in core (dbt-labs/dbt-core#10813). Sincevarsas a field never went out in a GA release of dbt-core, it is safe for us to drop it.