-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microbatch Config Validation #10752
Microbatch Config Validation #10752
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10752 +/- ##
=======================================
Coverage 88.98% 88.99%
=======================================
Files 181 181
Lines 23059 23093 +34
=======================================
+ Hits 20520 20551 +31
- Misses 2539 2542 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All this looks good to me 🙂
schemas PR: dbt-labs/schemas.getdbt.com#58 |
5660d01
to
165507a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Looks good
Resolves #10709
Problem
We either don't validate configs for microbatch models or validate them during execution. We need parse-time validation to ensure that required fields are present and typed correctly:
Additionally, any inputs to a microbatch model that have an event_time config must have that event_time config be a string.
Solution
Checklist