-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add required 'begin' config support for microbatch models #10756
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
1 similar comment
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10756 +/- ##
==========================================
+ Coverage 88.97% 89.04% +0.06%
==========================================
Files 181 181
Lines 22956 22984 +28
==========================================
+ Hits 20424 20465 +41
+ Misses 2532 2519 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
|
CI should pass once dbt-labs/schemas.getdbt.com#57 is merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woooo! This looks great 😄 I made one comment on updating a doc string, and we should probably fix it before merging, but also didn't want my review to be blocking as you'll be back online before I am.
Resolves #10701
Problem
We need to know what the "beginning of time" is for a microbatch model, to know when to start for these two cases:
This is distinct from the CLI parameter --event-time-start which can also be used when running in "incremental" mode.
Solution
begin
config! (raise exception if its not available, and further parse-time validation will be introduced as part of Microbatch Config Validation #10752begin
config.Checklist