Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin macos test runners to macos-12 #10031

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Pin macos test runners to macos-12 #10031

merged 1 commit into from
Apr 25, 2024

Conversation

mikealfare
Copy link
Contributor

Problem

macos-latest now points to macos-14-arm64; it used to point to macos-12. There is no py39 nor py38 on macos-14-arm64.

Solution

Pin to macos-12 for now and discuss long term options to use macos-14-arm64, and CI pinning in general.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare added cla:yes Skip Changelog Skips GHA to check for changelog file labels Apr 25, 2024
@mikealfare mikealfare self-assigned this Apr 25, 2024
@mikealfare mikealfare requested a review from a team as a code owner April 25, 2024 02:49
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.14%. Comparing base (1e4bed0) to head (7120075).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10031      +/-   ##
==========================================
- Coverage   88.16%   88.14%   -0.02%     
==========================================
  Files         181      181              
  Lines       22643    22643              
==========================================
- Hits        19963    19959       -4     
- Misses       2680     2684       +4     
Flag Coverage Δ
integration 85.44% <ø> (-0.02%) ⬇️
unit 62.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's test with py-3.11 on macos

@emmyoop emmyoop merged commit bcbde3a into main Apr 25, 2024
66 checks passed
@emmyoop emmyoop deleted the pin-macos-runners branch April 25, 2024 13:29
github-actions bot pushed a commit that referenced this pull request Apr 25, 2024
Copy link
Contributor

The backport to 1.6.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.6.latest 1.6.latest
# Navigate to the new working tree
cd .worktrees/backport-1.6.latest
# Create a new branch
git switch --create backport-10031-to-1.6.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bcbde3ac4204f00d964a3ea60896b6af1df18c71
# Push it to GitHub
git push --set-upstream origin backport-10031-to-1.6.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.6.latest

Then, create a pull request where the base branch is 1.6.latest and the compare/head branch is backport-10031-to-1.6.latest.

emmyoop pushed a commit that referenced this pull request Apr 25, 2024
emmyoop pushed a commit that referenced this pull request Apr 25, 2024
emmyoop pushed a commit that referenced this pull request Apr 25, 2024
# Conflicts:
#	.github/workflows/main.yml
emmyoop pushed a commit that referenced this pull request Apr 25, 2024
# Conflicts:
#	.github/workflows/main.yml
emmyoop pushed a commit that referenced this pull request Apr 25, 2024
emmyoop pushed a commit that referenced this pull request Apr 25, 2024
# Conflicts:
#	.github/workflows/main.yml
#	.github/workflows/test-repeater.yml
emmyoop pushed a commit that referenced this pull request Apr 25, 2024
# Conflicts:
#	.github/workflows/main.yml
#	.github/workflows/test-repeater.yml
emmyoop added a commit that referenced this pull request Apr 25, 2024
emmyoop added a commit that referenced this pull request Apr 25, 2024
emmyoop added a commit that referenced this pull request Apr 25, 2024
# Conflicts:
#	.github/workflows/main.yml

Co-authored-by: Mike Alfare <[email protected]>
emmyoop added a commit that referenced this pull request Apr 25, 2024
# Conflicts:
#	.github/workflows/main.yml

Co-authored-by: Mike Alfare <[email protected]>
emmyoop added a commit that referenced this pull request Apr 25, 2024
emmyoop added a commit that referenced this pull request Apr 25, 2024
# Conflicts:
#	.github/workflows/main.yml
#	.github/workflows/test-repeater.yml

Co-authored-by: Mike Alfare <[email protected]>
martynydbt pushed a commit that referenced this pull request Apr 25, 2024
(cherry picked from commit bcbde3a)

Co-authored-by: Mike Alfare <[email protected]>
emmyoop added a commit that referenced this pull request Apr 26, 2024
# Conflicts:
#	.github/workflows/main.yml
#	.github/workflows/test-repeater.yml

Co-authored-by: Mike Alfare <[email protected]>
@aranke aranke mentioned this pull request Jul 12, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants