-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin macos
test runners to macos-12
#10031
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10031 +/- ##
==========================================
- Coverage 88.16% 88.14% -0.02%
==========================================
Files 181 181
Lines 22643 22643
==========================================
- Hits 19963 19959 -4
- Misses 2680 2684 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's test with py-3.11 on macos
(cherry picked from commit bcbde3a)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.6.latest 1.6.latest
# Navigate to the new working tree
cd .worktrees/backport-1.6.latest
# Create a new branch
git switch --create backport-10031-to-1.6.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bcbde3ac4204f00d964a3ea60896b6af1df18c71
# Push it to GitHub
git push --set-upstream origin backport-10031-to-1.6.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.6.latest Then, create a pull request where the |
# Conflicts: # .github/workflows/main.yml
# Conflicts: # .github/workflows/main.yml
# Conflicts: # .github/workflows/main.yml # .github/workflows/test-repeater.yml
# Conflicts: # .github/workflows/main.yml # .github/workflows/test-repeater.yml
Co-authored-by: Mike Alfare <[email protected]>
Co-authored-by: Mike Alfare <[email protected]>
# Conflicts: # .github/workflows/main.yml Co-authored-by: Mike Alfare <[email protected]>
# Conflicts: # .github/workflows/main.yml Co-authored-by: Mike Alfare <[email protected]>
Co-authored-by: Mike Alfare <[email protected]>
# Conflicts: # .github/workflows/main.yml # .github/workflows/test-repeater.yml Co-authored-by: Mike Alfare <[email protected]>
(cherry picked from commit bcbde3a) Co-authored-by: Mike Alfare <[email protected]>
# Conflicts: # .github/workflows/main.yml # .github/workflows/test-repeater.yml Co-authored-by: Mike Alfare <[email protected]>
Problem
macos-latest
now points tomacos-14-arm64
; it used to point tomacos-12
. There is nopy39
norpy38
onmacos-14-arm64
.Solution
Pin to
macos-12
for now and discuss long term options to usemacos-14-arm64
, and CI pinning in general.Checklist