Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add draft flag #49

Merged
merged 51 commits into from
Aug 10, 2023
Merged

add draft flag #49

merged 51 commits into from
Aug 10, 2023

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Jul 7, 2023

resolves #39

Bundles will always be created in draft. There are additional workflows to publish the releases out of draft status.

The full release workflow (create craft, test and publish) will not work until the 3.11 failures are resolved.

@emmyoop emmyoop marked this pull request as draft July 7, 2023 18:45
@emmyoop emmyoop force-pushed the er/add-drafts branch 3 times, most recently from 861a4cb to 942450f Compare July 20, 2023 21:39
Copy link
Contributor

@colin-rogers-dbt colin-rogers-dbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple thoughts but this looks pretty close to ready to me

.github/actions/test_install/action.yml Show resolved Hide resolved
release_creation/github_client/releases.py Outdated Show resolved Hide resolved
release_creation/github_client/releases.py Outdated Show resolved Hide resolved
logger.info(f"Retrieved latest version: {latest_version} "
f"and latest release: {latest_release.tag_name if latest_release else None}")
if operation == ReleaseOperations.create:
if is_draft:
raise RuntimeError(f"A draft release already exists for version {latest_version}. It needs to be published or deleted first")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@emmyoop emmyoop marked this pull request as ready for review August 4, 2023 17:21
@colin-rogers-dbt colin-rogers-dbt merged commit fe9d3e7 into main Aug 10, 2023
4 of 6 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the er/add-drafts branch August 10, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create 'draft' releases to test changes to github actions
2 participants