Skip to content

Commit

Permalink
use version object
Browse files Browse the repository at this point in the history
  • Loading branch information
emmyoop committed Jul 20, 2023
1 parent 5b0cf84 commit 942450f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions release_creation/github_client/releases.py
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,8 @@ def _compare_reqs(bundle_req: List[str], release_req: List[str]) -> Tuple[Set[st
return added_req, removed_req


def generate_download_urls(release: GitRelease) -> Tuple[str, str]:
bundle_config = get_bundle_config(target_version=release.tag_name)
def generate_download_urls(release: GitRelease, version: Version) -> Tuple[str, str]:
bundle_config = get_bundle_config(target_version=version)
created_asset_name = f"bundle_core_all_adapters_{bundle_config.local_os}_{bundle_config.py_major_minor}.zip"
req_file_name = f"{BUNDLE_REQ_NAME_PREFIX}_{bundle_config.local_os}_{bundle_config.py_major_minor}.txt"

Expand Down
4 changes: 2 additions & 2 deletions release_creation/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,13 @@ def main():
latest_release=latest_release,
draft=draft
)
created_asset_url, req_file_url = generate_download_urls(release=created_release)
created_asset_url, req_file_url = generate_download_urls(release=created_release, version=target_version)
set_output(name="created_tag", value=created_release.tag_name)
set_output(name="created_asset_url", value=created_asset_url)
set_output(name="req_file_url", value=req_file_url)
elif operation == ReleaseOperations.update:
bundle_assets = generate_bundle(latest_version)
created_asset_url, req_file_url = generate_download_urls(release=latest_release)
created_asset_url, req_file_url = generate_download_urls(release=latest_release, version=latest_version)

logger.debug(f"latest_release: {latest_release}")
# add_assets_to_release(assets=bundle_assets, latest_release=latest_release)
Expand Down

0 comments on commit 942450f

Please sign in to comment.