-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: increase iceberg retries in integration tests #746
fix: increase iceberg retries in integration tests #746
Conversation
Integration tests seem to be failing because there is a missing region @mikealfare I believe that the issue is because here, my user (and every other user that contribute) don't have access to the variable. |
The region is there. This looks like it's related to the aws-creds action. It started failing for me after last night for v2, but v4 passes. I have another PR that was affectd that has that fix. So when I get that merged in, I'll sync this PR and all should be fine |
@mikealfare any updates here? Integrations tests seems still not working, even after merging the latest from the main branch |
Turning it off and on again |
Description
The iceberg retries integration test is the most problematic. Sometimes, it passes, and sometimes, it does not.
Currently the test dues 10 parallel inserts. The idea of this PR is to increase num_iceberg_retries to a value big enough, to allow the test to pass.
Checklist