Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run on pull_request_target to pick up environment variables and secrets on forks #750

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Oct 24, 2024

Checklist

  • You followed contributing section
  • You kept your Pull Request small and focused on a single feature or bug fix.
  • You added unit testing when necessary
  • You added functional testing when necessary

@mikealfare mikealfare requested a review from a team as a code owner October 24, 2024 00:33
@mikealfare mikealfare changed the title un on pull request target to pick up environment vars and secrets on… Run on `pull_requesttarget to pick up environment vars and secrets on… Oct 24, 2024
@mikealfare mikealfare changed the title Run on `pull_requesttarget to pick up environment vars and secrets on… Run on pull_request_target to pick up environment variables and secrets on forks Oct 24, 2024
@mikealfare mikealfare self-assigned this Oct 24, 2024
@mikealfare mikealfare enabled auto-merge (squash) October 24, 2024 00:35
@mikealfare
Copy link
Contributor Author

The checks aren't running because this branch does not have a trigger (this branch says to look at main) and main does not have a trigger (main says to look at the incoming branch). Once this is merged, the next PR should trigger the same checks since then main will get triggered on a PR.

@nicor88
Copy link
Contributor

nicor88 commented Oct 24, 2024

@mikealfare good catch here, we faced this issue back then on PR coming from a fork, should resolve the issue on #746

@mikealfare mikealfare merged commit 8b3387f into main Oct 28, 2024
6 checks passed
@mikealfare mikealfare deleted the fix-integration-tests branch October 28, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants