Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: Add articles for hacktoberfest 2021, fix typo in old article #687

Merged
merged 16 commits into from
Sep 29, 2021
Merged

Draft: Add articles for hacktoberfest 2021, fix typo in old article #687

merged 16 commits into from
Sep 29, 2021

Conversation

mal-tee
Copy link
Member

@mal-tee mal-tee commented Sep 21, 2021 •
edited by baltpeter
Loading

Todo:

@mal-tee mal-tee requested a review from baltpeter September 21, 2021 16:30
@cypress
Copy link

cypress bot commented Sep 21, 2021 •
edited
Loading


Test summary

57 • 0 • 7 • 0

Run details
Project datenanfragen/website
Status Passed
Commit a4acb90
Started Sep 29, 2021 4:59 PM
Ended Sep 29, 2021 5:02 PM
Duration 03:00 💡
OS Linux Debian - 10.3
Browser Electron 87

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

baltpeter
baltpeter requested changes Sep 22, 2021
View reviewed changes
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

  • Regarding the featured images: Can you adjust the filters to make them a little more colorful please? At the moment, they don't really fit with the others and I'm not too happy about the contrast with the text.

content/de/blog/hacktoberfest-2021/index.md Outdated Show resolved Hide resolved
content/de/blog/hacktoberfest-2021/index.md Outdated Show resolved Hide resolved
content/de/blog/hacktoberfest-2021/index.md Outdated Show resolved Hide resolved
content/de/blog/hacktoberfest-2021/index.md Outdated Show resolved Hide resolved
content/de/blog/hacktoberfest-2021/index.md Outdated Show resolved Hide resolved
content/en/blog/hacktoberfest-2021/index.md Outdated Show resolved Hide resolved
content/en/blog/hacktoberfest-2021/index.md Outdated Show resolved Hide resolved
content/en/blog/hacktoberfest-2021/index.md Outdated Show resolved Hide resolved
content/en/blog/hacktoberfest-2021/index.md Outdated Show resolved Hide resolved
content/en/blog/hacktoberfest-2021/index.md Outdated Show resolved Hide resolved
@mal-tee @baltpeter
Apply suggestions from code review
257c882 
Co-authored-by: Benjamin Altpeter <[email protected]>
@mal-tee mal-tee requested a review from baltpeter September 23, 2021 09:22
baltpeter
baltpeter requested changes Sep 24, 2021
View reviewed changes
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just a couple more comments and after that I'm happy to approve this.

content/en/blog/hacktoberfest-2021/index.md Outdated Show resolved Hide resolved
content/en/blog/hacktoberfest-2021/index.md Outdated Show resolved Hide resolved
content/en/blog/hacktoberfest-2021/index.md Outdated Show resolved Hide resolved
content/de/blog/hacktoberfest-2021/index.md Outdated Show resolved Hide resolved
content/de/blog/hacktoberfest-2021/index.md Show resolved Hide resolved
content/en/blog/hacktoberfest-2021/index.md Outdated Show resolved Hide resolved
content/de/blog/hacktoberfest-2021/index.md Outdated Show resolved Hide resolved
content/en/blog/hacktoberfest-2021/index.md Outdated Show resolved Hide resolved
content/de/blog/hacktoberfest-2021/index.md Outdated Show resolved Hide resolved
content/de/blog/hacktoberfest-2021/index.md Outdated Show resolved Hide resolved
@baltpeter baltpeter self-assigned this Sep 27, 2021
baltpeter
baltpeter previously approved these changes Sep 27, 2021
View reviewed changes
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter marked this pull request as ready for review September 29, 2021 16:52
@baltpeter baltpeter merged commit 0b52451 into master Sep 29, 2021
@baltpeter baltpeter deleted the m_htf_articles branch September 29, 2021 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zner0L zner0L zner0L left review comments

@baltpeter baltpeter baltpeter approved these changes

Assignees

@baltpeter baltpeter

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mal-tee @baltpeter @zner0L