-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZDM Util: upgrade Go version and some of its dependencies #70
Merged
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c7d5696
Upgrade runc dependency + fixed compilation error from previous chang…
alicel 4225dc7
Upgraded go to 1.21.7
alicel 2c791d1
Reverted docker upgrade due to incompatibility with other dependencies
alicel 0b79139
updated dependencies
alicel 0bfecfe
Changed version format to comply with build action requirements
alicel 243dbf3
Removed unnecessary dependencies from go.mod
alicel 8f2381a
Change to dependencies from go.mod
alicel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,35 @@ | ||
| module zdm-proxy-automation/zdm-util | ||
|
|
||
| go 1.16 | ||
| go 1.21.7 | ||
|
|
||
| require ( | ||
| github.com/containerd/containerd v1.6.8 // indirect | ||
| github.com/containerd/continuity v0.3.0 // indirect | ||
| github.com/docker/distribution v2.8.1+incompatible // indirect | ||
| github.com/docker/docker v20.10.17+incompatible | ||
| github.com/moby/sys/mount v0.3.3 // indirect | ||
| github.com/moby/term v0.0.0-20220808134915-39b0c02b01ae // indirect | ||
| github.com/opencontainers/runc v1.1.4 // indirect | ||
| github.com/phayes/permbits v0.0.0-20190612203442-39d7c581d2ee // indirect | ||
| github.com/docker/docker v23.0.3+incompatible | ||
| github.com/phayes/permbits v0.0.0-20190612203442-39d7c581d2ee | ||
| github.com/pkg/errors v0.9.1 | ||
| github.com/sirupsen/logrus v1.9.0 // indirect | ||
| github.com/stretchr/testify v1.8.0 | ||
| golang.org/x/sys v0.0.0-20220829200755-d48e67d00261 // indirect | ||
| golang.org/x/time v0.0.0-20220722155302-e5dcc9cfc0b9 // indirect | ||
| gotest.tools/v3 v3.3.0 // indirect | ||
| github.com/stretchr/testify v1.8.4 | ||
| ) | ||
|
|
||
| require ( | ||
| github.com/Azure/go-ansiterm v0.0.0-20230124172434-306776ec8161 // indirect | ||
| github.com/Microsoft/go-winio v0.6.1 // indirect | ||
| github.com/containerd/containerd v1.7.13 // indirect | ||
| github.com/davecgh/go-spew v1.1.1 // indirect | ||
| github.com/docker/go-connections v0.5.0 // indirect | ||
| github.com/docker/go-units v0.5.0 // indirect | ||
| github.com/gogo/protobuf v1.3.2 // indirect | ||
| github.com/google/go-cmp v0.6.0 // indirect | ||
| github.com/klauspost/compress v1.17.7 // indirect | ||
| github.com/moby/patternmatcher v0.6.0 // indirect | ||
| github.com/moby/sys/sequential v0.5.0 // indirect | ||
| github.com/moby/term v0.5.0 // indirect | ||
| github.com/morikuni/aec v1.0.0 // indirect | ||
| github.com/opencontainers/go-digest v1.0.0 // indirect | ||
| github.com/opencontainers/image-spec v1.1.0 // indirect | ||
| github.com/pmezard/go-difflib v1.0.0 // indirect | ||
| github.com/sirupsen/logrus v1.9.3 // indirect | ||
| golang.org/x/mod v0.15.0 // indirect | ||
| golang.org/x/sys v0.17.0 // indirect | ||
| golang.org/x/tools v0.18.0 // indirect | ||
| gopkg.in/yaml.v3 v3.0.1 // indirect | ||
| gotest.tools/v3 v3.5.1 // indirect | ||
| ) | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure the go sdk being installed supports this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot that we have a workflow that can build from a commit, I'll do that to verify that the executable can be built.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The executable could be built - I had to use 1.21 instead of 1.21.7 and fix two dependencies that were missing from go.sum and therefore showed as unnecessary in go.mod. The 1.21 version in itself did not cause issues, but it was useful to run the workflow from the commit.