ZDM Util: upgrade Go version and some of its dependencies #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weideng1
approved these changes
Feb 29, 2024
joao-r-reis
reviewed
Feb 29, 2024
zdm-util/go.mod
Outdated
| @@ -1,20 +1,35 @@ | |||
| module zdm-proxy-automation/zdm-util | |||
|
|
|||
| go 1.16 | |||
| go 1.21.7 | |||
There was a problem hiding this comment.
Are we sure the go sdk being installed supports this?
There was a problem hiding this comment.
I forgot that we have a workflow that can build from a commit, I'll do that to verify that the executable can be built.
There was a problem hiding this comment.
The executable could be built - I had to use 1.21 instead of 1.21.7 and fix two dependencies that were missing from go.sum and therefore showed as unnecessary in go.mod. The 1.21 version in itself did not cause issues, but it was useful to run the workflow from the commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only affects the ZDM Util.
The changes include an upgrade of the Go version from 1.16 to 1.21.7, and upgrading several dependencies that were outdated. In particular, the runc transitive dependency has been upgraded from 1.1.4 to 1.1.12 to address a security vulnerability.
Additionally, there is a fix for a small compilation error in a test which had gone unnoticed since the changes to make the ZDM Util OS-agnostic.
The automated tests are passing and a manual smoke test was also successful.