fix properties.name mapping

datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/dataprocessinst/mappers/DataProcessInstanceMapper.java

@@ -147,9 +147,7 @@ private void mapDataProcessProperties(
               dataProcessInstanceProperties.getCustomProperties(), entityUrn));
     }
     if (dataProcessInstanceProperties.hasCreated()) {
-      com.linkedin.datahub.graphql.generated.AuditStamp created =
-          AuditStampMapper.map(context, dataProcessInstanceProperties.getCreated());
-      properties.setCreated(created);
+      dpi.setCreated(AuditStampMapper.map(context, dataProcessInstanceProperties.getCreated()));
     }
     dpi.setProperties(properties);
   }

datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/mlmodel/mappers/MLModelGroupPropertiesMapper.java

@@ -40,6 +40,12 @@ public MLModelGroupProperties apply(
       result.setCreated(
           TimeStampToAuditStampMapper.map(context, mlModelGroupProperties.getCreated()));
     }
+    if (mlModelGroupProperties.getName() != null) {
+      result.setName(mlModelGroupProperties.getName());
+    } else {
+      // backfill name from URN for backwards compatibility
+      result.setName(entityUrn.getEntityKey().get(1)); // indexed access is safe here
+    }
 
     if (mlModelGroupProperties.hasLastModified()) {
       result.setLastModified(

datahub-graphql-core/src/test/java/com/linkedin/datahub/graphql/types/mlmodel/mappers/MLModelGroupPropertiesMapperTest.java

@@ -19,6 +19,9 @@ public void testMapMLModelGroupProperties() throws URISyntaxException {
     // Set description
     input.setDescription("a ml trust model group");
 
+    // Set Name
+    input.setName("ML trust model group");
+
     // Create URN
     Urn groupUrn =
         Urn.createFromString(
@@ -31,6 +34,7 @@ public void testMapMLModelGroupProperties() throws URISyntaxException {
     // Verify mapped properties
     assertNotNull(result);
     assertEquals(result.getDescription(), "a ml trust model group");
+    assertEquals(result.getName(), "ML trust model group");
 
     // Verify lineage info is null as in the mock data
     assertNotNull(result.getMlModelLineageInfo());

datahub-web-react/src/app/entity/mlModel/preview/Preview.tsx

@@ -21,7 +21,7 @@ export const Preview = ({
     return (
         <DefaultPreviewCard
             url={entityRegistry.getEntityUrl(EntityType.Mlmodel, model.urn)}
-            name={model.name || ''}
+            name={model.properties?.['propertiesName'] || model.name || ''}
             urn={model.urn}
             description={model.description || ''}
             platformInstanceId={model.dataPlatformInstance?.instanceId}

datahub-web-react/src/app/entity/mlModelGroup/MLModelGroupEntity.tsx

@@ -139,7 +139,7 @@ export class MLModelGroupEntity implements Entity<MlModelGroup> {
     };
 
     displayName = (data: MlModelGroup) => {
-        return data.name || data.urn;
+        return data.properties?.name || data.name || data.urn;
     };
 
     getGenericEntityProperties = (mlModelGroup: MlModelGroup) => {

datahub-web-react/src/app/entity/mlModelGroup/preview/Preview.tsx

@@ -19,7 +19,7 @@ export const Preview = ({
     return (
         <DefaultPreviewCard
             url={entityRegistry.getEntityUrl(EntityType.MlmodelGroup, group.urn)}
-            name={group?.name || ''}
+            name={group?.properties?.['propertiesName'] || group?.name || ''}
             urn={group.urn}
             platformInstanceId={group.dataPlatformInstance?.instanceId}
             description={group?.description || ''}

datahub-web-react/src/app/entity/mlModelGroup/profile/ModelGroupModels.tsx

@@ -67,134 +67,134 @@
 export default function MLGroupModels() {
     const baseEntity = useBaseEntity<GetMlModelGroupQuery>();
     const entityRegistry = useEntityRegistry();
     const modelGroup = baseEntity?.mlModelGroup;
 
     const models =
         baseEntity?.mlModelGroup?.incoming?.relationships
             ?.map((relationship) => relationship.entity)
             .filter(notEmpty) || [];
 
     const columns = [
         {
             title: 'Name',
             dataIndex: 'name',
             key: 'name',
             width: 300,
-            render: (name, record) => (
+            render: (_: any, record) => (
                 <NameContainer>
-                    <NameLink href={entityRegistry.getEntityUrl(EntityType.Mlmodel, record.urn)}>{name}</NameLink>
+                    <NameLink href={entityRegistry.getEntityUrl(EntityType.Mlmodel, record.urn)}>{record?.properties?.propertiesName || record?.name }</NameLink>
                 </NameContainer>
             ),
         },
         {
             title: 'Version',
             key: 'version',
             width: 70,
             render: (_: any, record: any) => (
                 <VersionContainer>{record.versionProperties?.version?.versionTag || '-'}</VersionContainer>
             ),
         },
         {
             title: 'Created At',
             key: 'createdAt',
             width: 150,
             render: (_: any, record: any) => (
                 <Typography.Text>
                     {record.properties?.createdTS?.time
                         ? moment(record.properties.createdTS.time).format('YYYY-MM-DD HH:mm:ss')
                         : '-'}
                 </Typography.Text>
             ),
         },
         {
             title: 'Aliases',
             key: 'aliases',
             width: 200,
             render: (_: any, record: any) => {
                 const aliases = record.versionProperties?.aliases || [];
 
                 return (
                     <TagContainer>
                         {aliases.map((alias) => (
                             <Pill
                                 key={alias.versionTag}
                                 label={alias.versionTag}
                                 colorScheme="blue"
                                 clickable={false}
                             />
                         ))}
                     </TagContainer>
                 );
             },
         },
         {
             title: 'Tags',
             key: 'tags',
             width: 200,
             render: (_: any, record: any) => {
                 const tags = record.properties?.tags || [];
 
                 return (
                     <TagContainer>
                         {tags.map((tag) => (
                             <Pill key={tag} label={tag} clickable={false} />
                         ))}
                     </TagContainer>
                 );
             },
         },
         {
             title: 'Description',
             dataIndex: 'description',
             key: 'description',
             width: 300,
             render: (_: any, record: any) => {
                 const editableDesc = record.editableProperties?.description;
                 const originalDesc = record.description;
 
                 return <Typography.Text>{editableDesc || originalDesc || '-'}</Typography.Text>;
             },
         },
     ];
 
     return (
         <ModelsContainer>
             <Typography.Title level={3}>Model Group Details</Typography.Title>
             <InfoItemContainer justifyContent="left">
                 <InfoItem title="Created At">
                     <InfoItemContent>
                         {modelGroup?.properties?.created?.time
                             ? moment(modelGroup.properties.created.time).format('YYYY-MM-DD HH:mm:ss')
                             : '-'}
                     </InfoItemContent>
                 </InfoItem>
                 <InfoItem title="Last Modified At">
                     <InfoItemContent>
                         {modelGroup?.properties?.lastModified?.time
                             ? moment(modelGroup.properties.lastModified.time).format('YYYY-MM-DD HH:mm:ss')
                             : '-'}
                     </InfoItemContent>
                 </InfoItem>
                 {modelGroup?.properties?.created?.actor && (
                     <InfoItem title="Created By">
                         <InfoItemContent>{modelGroup.properties.created?.actor}</InfoItemContent>
                     </InfoItem>
                 )}
             </InfoItemContainer>
             <Typography.Title level={3}>Models</Typography.Title>
             <StyledTable
                 columns={columns}
                 dataSource={models}
                 pagination={false}
                 rowKey="urn"
                 expandable={{
                     defaultExpandAllRows: true,
                     expandRowByClick: true,
                 }}
                 locale={{
                     emptyText: <EmptyTab tab="mlModel" />,
                 }}
             />
         </ModelsContainer>
     );
 }

datahub-web-react/src/app/shared/time/timeUtils.tsx

@@ -208,39 +208,39 @@
 }
 
 export function formatDuration(durationMs: number): string {
     const duration = moment.duration(durationMs);
     const hours = Math.floor(duration.asHours());
     const minutes = duration.minutes();
     const seconds = duration.seconds();
 
     if (hours === 0 && minutes === 0) {
-        return `${seconds}secs`;
+        return `${seconds} secs`;
     }
 
     if (hours === 0) {
         return minutes === 1 ? `${minutes} min` : `${minutes} mins`;
     }
 
     const minuteStr = minutes > 0 ? ` ${minutes} mins` : '';
     return hours === 1 ? `${hours} hr${minuteStr}` : `${hours} hrs${minuteStr}`;
 }
 
 export function formatDetailedDuration(durationMs: number): string {
     const duration = moment.duration(durationMs);
     const hours = Math.floor(duration.asHours());
     const minutes = duration.minutes();
     const seconds = duration.seconds();
 
     const parts: string[] = [];
 
     if (hours > 0) {
         parts.push(hours === 1 ? `${hours} hr` : `${hours} hrs`);
     }
     if (minutes > 0) {
         parts.push(minutes === 1 ? `${minutes} min` : `${minutes} mins`);
     }
     if (seconds > 0) {
         parts.push(`${seconds} secs`);
     }
     return parts.join(' ');
 }

datahub-web-react/src/graphql/lineage.graphql

@@ -272,6 +272,7 @@ fragment lineageNodeProperties on EntityWithRelationships {
             removed
         }
         properties {
+            propertiesName: name
             createdTS: created {
                 time
                 actor
@@ -322,6 +323,7 @@ fragment lineageNodeProperties on EntityWithRelationships {
             comment
         }
         properties {
+            propertiesName: name
             createdTS: created {
                 time
                 actor

datahub-web-react/src/graphql/search.graphql

@@ -886,6 +886,9 @@ fragment searchResultsWithoutSchemaField on Entity {
                 ...structuredPropertiesFields
             }
         }
+        properties {
+            propertiesName: name 
+        }
     }
     ... on MLModelGroup {
         name
@@ -908,6 +911,9 @@ fragment searchResultsWithoutSchemaField on Entity {
                 ...structuredPropertiesFields
             }
         }
+        properties {
+            propertiesName: name
+        }
     }
     ... on Tag {
         name