Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update ml system UI #12334

Merged
merged 57 commits into from
Jan 29, 2025

Conversation

yoonhyejin
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 41.22658% with 345 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...p/entity/mlModelGroup/profile/ModelGroupModels.tsx 31.74% 129 Missing ⚠️
.../src/app/entity/mlModel/profile/MLModelSummary.tsx 31.91% 64 Missing ⚠️
...essInstance/profile/DataProcessInstanceSummary.tsx 39.21% 62 Missing ⚠️
...atahub-web-react/src/app/shared/time/timeUtils.tsx 10.52% 34 Missing ⚠️
...src/app/preview/DataProcessInstanceRightColumn.tsx 73.56% 23 Missing ⚠️
.../dataProcessInstance/DataProcessInstanceEntity.tsx 25.00% 15 Missing ⚠️
...app/entity/dataProcessInstance/preview/Preview.tsx 0.00% 10 Missing ⚠️
...b-react/src/app/entity/mlModel/preview/Preview.tsx 0.00% 2 Missing ⚠️
...ct/src/app/entity/mlModelGroup/preview/Preview.tsx 0.00% 2 Missing ⚠️
datahub-web-react/src/app/entity/EntityPage.tsx 0.00% 1 Missing ⚠️
... and 3 more

❌ Your patch status has failed because the patch coverage (41.22%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Files with missing lines Coverage Δ
...tahub-web-react/src/app/entity/shared/constants.ts 94.95% <100.00%> (+0.17%) ⬆️
...b-web-react/src/app/preview/DefaultPreviewCard.tsx 91.82% <100.00%> (+0.16%) ⬆️
datahub-web-react/src/app/entity/EntityPage.tsx 29.03% <0.00%> (-0.32%) ⬇️
...web-react/src/app/entity/mlModel/MLModelEntity.tsx 40.11% <0.00%> (ø)
...src/app/entity/mlModelGroup/MLModelGroupEntity.tsx 40.85% <0.00%> (ø)
...onents/styled/search/EmbeddedListSearchSection.tsx 38.74% <96.15%> (+8.62%) ⬆️
...b-react/src/app/entity/mlModel/preview/Preview.tsx 22.50% <0.00%> (-0.58%) ⬇️
...ct/src/app/entity/mlModelGroup/preview/Preview.tsx 21.62% <0.00%> (-0.61%) ⬇️
...app/entity/dataProcessInstance/preview/Preview.tsx 19.41% <0.00%> (ø)
.../dataProcessInstance/DataProcessInstanceEntity.tsx 30.21% <25.00%> (-0.88%) ⬇️
... and 5 more

... and 43 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79aa40f...2b9a418. Read the comment docs.

@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Jan 28, 2025
@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Jan 28, 2025
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Jan 28, 2025
@yoonhyejin yoonhyejin changed the title feat: update ml system related UI feat: update ml system UI Jan 28, 2025
Copy link
Collaborator

@asikowitz asikowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Jan 28, 2025
@asikowitz
Copy link
Collaborator

Merging through smoke test failure as it exists on master

@asikowitz asikowitz merged commit 47134c2 into datahub-project:master Jan 29, 2025
151 of 160 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-submitter-merge product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants