Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New feature : copy technologies from a clientspace to another #11

Merged
merged 4 commits into from
Nov 16, 2023
Merged

New feature : copy technologies from a clientspace to another #11

merged 4 commits into from
Nov 16, 2023

Conversation

drscholly
Copy link
Contributor

@drscholly drscholly commented Nov 3, 2023 •
edited
Loading

Fixes #6

Checklist

  • I have read the Contribution Guide ;
  • I have read the Contributor License Agreement (CLA) and understand that the submission of this PR will constitute an electronic signature of my agreement of the terms and conditions of DataGalaxy's CLA ;
  • There is an approved issue describing the change when contributing a new feature ;
  • I have added tests that prove my fix is effective or that my feature works ;
  • I have added necessary documentation (if appropriate) ;

Short description of what this resolves:

This PR adds a new feature to the codebase that allows to copy custom technologies (which are user created) from one clientspace to another.

Changes proposed in this pull request:

  • API methods to fetch technologies and insert
  • New parser option
  • Some tests

@drscholly
API: implement methods to get/post
b8d529b 
- list_technologies retrieves all technologies from a clientspace
- insert_technology creates a new technology in the clientspace
@drscholly drscholly requested a review from a team as a code owner November 3, 2023 16:48
@drscholly
Copy link
Contributor Author

Please release v0.3.0 after successful merge

ggrossetie
ggrossetie approved these changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@ggrossetie ggrossetie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a nitpick but otherwise 👍🏻

@ggrossetie ggrossetie mentioned this pull request Nov 15, 2023
Merged
5 tasks
@drscholly
toolbox: Implement copy-technologies method
db79d4b 
It fetches all existing technologies in the source clientspace.
Then, it finds the custom technologies in this list.
These custom technologies, if they do not exist in the
target clientspace, are created.
@drscholly
main: Add copy-technologies to parser options
c5a661d
@drscholly
tests: Implement two tests for copy-technologies
d1c390a 
- When no technology on source workspace
- When no custom technology on source workspace
@drscholly drscholly force-pushed the ft/technologies branch 3 times, most recently from 8e5987d to d1c390a Compare November 16, 2023 07:35
@ggrossetie ggrossetie merged commit 6709ce0 into datagalaxy-lab:main Nov 16, 2023
4 checks passed
@drscholly drscholly deleted the ft/technologies branch November 16, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggrossetie ggrossetie ggrossetie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Copy technologies
2 participants
@drscholly @ggrossetie