Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature: copy screens from one clientspace / workspace to another #14

Merged
merged 5 commits into from
Apr 9, 2024

Conversation

drscholly
Copy link
Contributor

@drscholly drscholly commented Nov 13, 2023

Fixes #12

Checklist

  • I have read the Contribution Guide ;
  • I have read the Contributor License Agreement (CLA) and understand that the submission of this PR will constitute an electronic signature of my agreement of the terms and conditions of DataGalaxy's CLA ;
  • There is an approved issue describing the change when contributing a new feature ;
  • I have added tests that prove my fix is effective or that my feature works ;
  • I have added necessary documentation (if appropriate) ;

Short description of what this resolves:

Changes proposed in this pull request:

  • Add new copy-screens command to the toolbox
  • It allows to copy screens from a clientspace or workspace to another clientspace or workspace
  • Is close to all other features of the toolbox

@drscholly drscholly requested a review from a team as a code owner November 13, 2023 15:22
@drscholly drscholly force-pushed the ft/screens branch 2 times, most recently from bbd9773 to 566a51c Compare November 13, 2023 15:31
@drscholly
Copy link
Contributor Author

Please release v0.4.0 after successful merge

@ggrossetie
Copy link
Collaborator

ggrossetie commented Nov 15, 2023

I guess this branch is based on #11 so we should probably merge #11 first and then rebase.

@sailro
Copy link
Member

sailro commented Nov 16, 2023

[x] have added necessary documentation (if appropriate) => README.md was not updated for recent PRs, could you make sure everything is up-to-date? (feel free to open a new "documentation" pr if that's more convenient). Thanks!

@ggrossetie
Copy link
Collaborator

@drscholly could you please rebase on main branch?

@drscholly drscholly force-pushed the ft/screens branch 2 times, most recently from 561765e to 62dd768 Compare November 16, 2023 16:09
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@drscholly drscholly force-pushed the ft/screens branch 4 times, most recently from c4b8fbc to f871ed5 Compare November 28, 2023 13:22
@drscholly drscholly force-pushed the ft/screens branch 2 times, most recently from 418932c to 09db22c Compare December 13, 2023 13:55
@ggrossetie ggrossetie merged commit 0ce5c65 into datagalaxy-lab:main Apr 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy screens from one workspace/clientspace to another
3 participants