-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev igd 45 #60
Merged
Merged
Dev igd 45 #60
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d17c7da
begin adding more tests to cover igd workflow
donaldcampbelljr 5c53208
change nCnts incrementing
donaldcampbelljr d28ff7d
do not reset nCnts, use it for tests
donaldcampbelljr 93fef4c
add fields to igd_t struct to help with testing during creation
donaldcampbelljr af8bbbc
some clean up
donaldcampbelljr 2998139
add new test_igd_create_then_load_from_disk
donaldcampbelljr 6f383aa
attempt to read from buffer for test_igd_create_then_load_from_disk f…
donaldcampbelljr 925c056
update test assertions
donaldcampbelljr e53e457
add igd test create then search
donaldcampbelljr 8f3dc68
potential fix #45, comment out debugging lines
donaldcampbelljr abaeb96
update rstest, use cases for new test, rethink source bedfiles and qu…
donaldcampbelljr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
chr1 1 100 | ||
chr1 200 300 | ||
chr1 32768 32868 | ||
chr1 49152 49352 | ||
chr2 1 100 | ||
chr2 200 300 | ||
chr3 32768 32868 | ||
chr3 49152 49352 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
chr1 1 100 | ||
chr1 200 300 | ||
chr1 32768 32868 | ||
chr1 49152 49352 | ||
chr2 1 100 | ||
chr2 200 300 | ||
chr3 32768 32868 | ||
chr3 49152 49352 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
chr2 652554 652780 SRX4150706.05_peak_5 157 . 2.14622 20.42377 15.73019 44 | ||
chr2 653837 654214 SRX4150706.05_peak_6 757 . 3.67362 82.37296 75.78497 191 | ||
chr11 951681 952010 SRX4150706.05_peak_247 205 . 11.82913 25.65609 20.56433 139 | ||
chr11 1248894 1249428 SRX4150706.05_peak_248 252 . 11.83432 30.63056 25.20567 179 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
chr1 1 100 | ||
chr1 200 300 | ||
chr1 32768 32868 | ||
chr1 49152 49352 | ||
chr2 1 100 | ||
chr2 200 300 | ||
chr3 32768 32868 | ||
chr3 49152 49352 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
chr3 49152 49352 | ||
chr2 653837 654214 SRX4150706.05_peak_6 757 . 3.67362 82.37296 75.78497 191 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
igd_t
a struct? What do you think about capitalizing it to be more "Rusty"?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At some point we can do a large refactor to tackle things like this. For example, some variables are named in a way that are not super clear. This is because they were ported directly from C code and I wanted to keep them aligned for troubleshooting purposes.