Dev igd 45 #60
Merged
Dev igd 45 #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or test assertions
…ery, remove local tests
|
This should fix issue #45. I also spent time going start to finish using igd create and then search and re-doing the tests to ensure that we have better coverage on both the create and search workflows. |
nleroy917
approved these changes
Dec 20, 2024
| } | ||
|
|
||
| /// Creates IGD database from a directory of bed files. | ||
| pub fn create_igd_f(output_path: &String, filelist: &String, db_output_name: &String) { | ||
| pub fn create_igd_f(output_path: &String, filelist: &String, db_output_name: &String) -> igd_t { |
There was a problem hiding this comment.
Is igd_t a struct? What do you think about capitalizing it to be more "Rusty"?
There was a problem hiding this comment.
At some point we can do a large refactor to tackle things like this. For example, some variables are named in a way that are not super clear. This is because they were ported directly from C code and I wanted to keep them aligned for troubleshooting purposes.
|
We can run cargo fmt on dev right before today's release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards solving #45 as well as adding better test coverage for IGD workflow