Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect average nthreads in adaptive #8041

Merged
merged 6 commits into from
Jul 28, 2023
Merged

Commits on Jul 27, 2023

  1. Respect average nthreads in adaptive

    Previously we would assume in adaptive that workers had a single core.
    
    Now we do a pass through all the workers to sum up the number of threads
    per machine and divide the recommendation by this amount.
    
    This is not very expensive
    
    ```python-console
    In [1]: class Worker:
       ...:     def __init__(self):
       ...:         self.cpu = 4
       ...:
    
    In [2]: workers = [Worker() for _ in range(1000)]
    
    In [3]: %timeit sum(w.cpu for w in workers)
    33.6 µs ± 170 ns per loop (mean ± std. dev. of 7 runs, 10,000 loops each)
    ```
    mrocklin committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    d8cfe21 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. Fix test_target_duration

    fjetter committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    a69d985 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d344eaa View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a977aa7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    645b184 View commit details
    Browse the repository at this point in the history
  5. Simpler

    hendrikmakait committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    2a2aedf View commit details
    Browse the repository at this point in the history